Removes unnecessary requests in config, inventory data or statistics #5460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
May 18, 2023
yenienserrano
changed the title
Desvelao
reviewed
May 26, 2023
Test
Legend: UI
Details 🟢 Check that the request is not made in "Stats"Chrome - 🟢 Firefox - 🟢 Safari - ⚫ 🟢 Check that the request is not made in "Inventory data"Chrome - 🟢 Firefox - 🟢 Safari - ⚫ 🟢 Check that the request is not made in "Configuration"Chrome - 🟢 Firefox - 🟢 Safari - ⚫ |
Desvelao
previously approved these changes
May 29, 2023
…ecessary-query-while-accessing
…ecessary-query-while-accessing
Tostti
approved these changes
May 29, 2023
There was a problem hiding this comment.
Test
- Navigate to
an agent - Click on
Inventory data | Stats | Configuration - Check that the request is not made:
GET /agents" with parameters {"agents_list": "002", "select": "status"}
Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable
UI
| Test | Chrome | Firefox | Safari |
|---|---|---|---|
| Check that the request is not made in "Stats" | 🟢 | 🟢 | ⚫ |
| Check that the request is not made in "Inventory data" | 🟢 | 🟢 | ⚫ |
| Check that the request is not made in "Configuration" | 🟢 | 🟢 | ⚫ |
Details
🟢 Check that the request is not made in "Stats"
Chrome - 🟢
Firefox - 🟢
Safari - ⚫
🟢 Check that the request is not made in "Inventory data"
Firefox - 🟢
Safari - ⚫
🟢 Check that the request is not made in "Configuration"
Chrome - 🟢
Firefox - 🟢
Safari - ⚫
TEST:✔️
CR:✔️
LGTM
|
Desvelao
approved these changes
May 29, 2023
yenienserrano
changed the title
AlexRuiz7
deleted the
5239-wazuh-api-usage-agent-inventory-data-unnecessary-query-while-accessing
branch
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.5-7.10 4.5-7.10
# Navigate to the new working tree
cd .worktrees/backport-4.5-7.10
# Create a new branch
git switch --create backport-5460-to-4.5-7.10
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f5be86d213db79fb42c8af9098660c961a3e1732
# Push it to GitHub
git push --set-upstream origin backport-5460-to-4.5-7.10
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.5-7.10Then, create a pull request where the |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.5-7.16 4.5-7.16
# Navigate to the new working tree
cd .worktrees/backport-4.5-7.16
# Create a new branch
git switch --create backport-5460-to-4.5-7.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f5be86d213db79fb42c8af9098660c961a3e1732
# Push it to GitHub
git push --set-upstream origin backport-5460-to-4.5-7.16
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.5-7.16Then, create a pull request where the |
AlexRuiz7
pushed a commit
that referenced
this pull request
May 30, 2023
… data or statistics (#5508) Removes unnecessary requests in config, inventory data or statistics (#5460) * Add dont make the queries in config or inventory * Update changelog * Fix stats request --------- Co-authored-by: Álex Ruiz <alejandro.ruiz.becerra@wazuh.com> (cherry picked from commit f5be86d)
AlexRuiz7
pushed a commit
that referenced
this pull request
May 30, 2023
… data or statistics (#5507) Removes unnecessary requests in config, inventory data or statistics (#5460) * Add dont make the queries in config or inventory * Update changelog * Fix stats request --------- Co-authored-by: Álex Ruiz <alejandro.ruiz.becerra@wazuh.com> (cherry picked from commit f5be86d)
8 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add to the buttons the parameter that controls if the request has to be made, and we delete a variable that was not used anywhere.
Issues Resolved
Evidence
Details
Inventory data
Configuration
Stats
Test
an agentInventory data | Stats | ConfigurationGET /agents" with parameters {"agents_list": "002", "select": "status"}Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable
UI
Details
⚫ Check that the request is not made in "Stats"
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ Check that the request is not made in "Inventory data"
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ Check that the request is not made in "Configuration"
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
Check List
yarn test:jest