Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 4.5-7.10]Removes unnecessary requests in config, inventory data or statistics #5508

Merged
merged 1 commit into from
May 30, 2023
Merged

[Backport 4.5-7.10]Removes unnecessary requests in config, inventory data or statistics #5508

merged 1 commit into from
May 30, 2023

Conversation

yenienserrano
Copy link
Member

Backport f5be86d from #5460.

@yenienserrano
Removes unnecessary requests in config, inventory data or statistics (#…
9a2e9da 
…5460)

* Add dont make the queries in config or inventory

* Update changelog

* Fix stats request

---------

Co-authored-by: Álex Ruiz <alejandro.ruiz.becerra@wazuh.com>
(cherry picked from commit f5be86d)
@yenienserrano yenienserrano requested a review from a team as a code owner May 30, 2023 07:26
This was linked to issues May 30, 2023
Wazuh API usage - Agent stats unnecessary queries while accessing #5238
Closed
Wazuh API usage - Agent inventory data unnecessary query while accessing #5239
Closed
Wazuh API usage - Agent configuration unnecessary queries while accessing #5240
Closed
@github-actions
Copy link
Contributor

Code coverage (Jest) % values
Statements 9.53% ( 3521 / 36931 )
Branches 5.01% ( 1434 / 28633 )
Functions 8.22% ( 752 / 9152 )
Lines 9.61% ( 3401 / 35372 )

@Desvelao
Copy link
Member

Test

  1. Navigate to an agent
  2. Click on Inventory data | Stats | Configuration
  3. Check that the request is not made: GET /agents" with parameters {"agents_list": "002", "select": "status"}

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

UI

Test Chrome Firefox Safari
Check that the request is not made in "Stats" 🟢 ⚫ ⚫
Check that the request is not made in "Inventory data" 🟢 ⚫ ⚫
Check that the request is not made in "Configuration" 🟢 ⚫ ⚫

Details

🟢 Check that the request is not made in "Stats"

Chrome - 🟢
image

Firefox - ⚫

Safari - ⚫

🟢 Check that the request is not made in "Inventory data"

Chrome - 🟢
image

Firefox - ⚫

Safari - ⚫

🟢 Check that the request is not made in "Configuration"

Chrome - 🟢
image

Firefox - ⚫

Safari - ⚫

Desvelao
Desvelao approved these changes May 30, 2023
View reviewed changes
Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review

code 🟢
test 🟢 #5508 (comment)

@AlexRuiz7 AlexRuiz7 merged commit 23545d9 into 4.5-7.10 May 30, 2023
@AlexRuiz7 AlexRuiz7 deleted the backport-5460-to-4.5-7.10 branch May 30, 2023 11:30
@AlexRuiz7 AlexRuiz7 changed the title [Backpoort 4.5-7.10]Removes unnecessary requests in config, inventory data or statistics [Backport 4.5-7.10]Removes unnecessary requests in config, inventory data or statistics May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Desvelao Desvelao Desvelao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@yenienserrano @Desvelao @AlexRuiz7