-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated code and request in Management #5485
Conversation
Management
Management
I didn't see any changes related to other problems reported in the issue is not solved:
@yenienserrano, Could you indicate if this was solved and where? |
This is not a change that we have to make, since it is being handled when the module is not activated. |
todo: remove the There are some tests definition and test snapshots that are using the |
todo: remove the Affected files:
|
Done |
|
TestLegend: UI
Details 🟢 Ensure that requests in management/configuration are not repeatedFirefox - ⚫ Safari - ⚫ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
review:
code 🟢
test 🟢 #5485 (comment)
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.5-7.10 4.5-7.10
# Navigate to the new working tree
cd .worktrees/backport-4.5-7.10
# Create a new branch
git switch --create backport-5485-to-4.5-7.10
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 13984520d84bdb07cb0d86f1f315cec4aa39dd84
# Push it to GitHub
git push --set-upstream origin backport-5485-to-4.5-7.10
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.5-7.10 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.5-7.16 4.5-7.16
# Navigate to the new working tree
cd .worktrees/backport-4.5-7.16
# Create a new branch
git switch --create backport-5485-to-4.5-7.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 13984520d84bdb07cb0d86f1f315cec4aa39dd84
# Push it to GitHub
git push --set-upstream origin backport-5485-to-4.5-7.16
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.5-7.16 Then, create a pull request where the |
* Remove deprecated code and request * Add changelog * Update snapshot * remove: remove clusterStatus unused variable * Remove clusterStatus property in groups-main.test.tsx --------- Co-authored-by: Antonio David Gutiérrez <antonio.gutierrez@wazuh.com> Co-authored-by: Federico Rodriguez <federico.rodriguez@wazuh.com> (cherry picked from commit 1398452)
* Remove deprecated code and request * Add changelog * Update snapshot * remove: remove clusterStatus unused variable * Remove clusterStatus property in groups-main.test.tsx --------- Co-authored-by: Antonio David Gutiérrez <antonio.gutierrez@wazuh.com> Co-authored-by: Federico Rodriguez <federico.rodriguez@wazuh.com> (cherry picked from commit 1398452)
…agement (#5550) Remove deprecated code and request in Management (#5485) * Remove deprecated code and request * Add changelog * Update snapshot * remove: remove clusterStatus unused variable * Remove clusterStatus property in groups-main.test.tsx --------- Co-authored-by: Antonio David Gutiérrez <antonio.gutierrez@wazuh.com> Co-authored-by: Federico Rodriguez <federico.rodriguez@wazuh.com> (cherry picked from commit 1398452)
…agement (#5549) Remove deprecated code and request in Management (#5485) * Remove deprecated code and request * Add changelog * Update snapshot * remove: remove clusterStatus unused variable * Remove clusterStatus property in groups-main.test.tsx --------- Co-authored-by: Antonio David Gutiérrez <antonio.gutierrez@wazuh.com> Co-authored-by: Federico Rodriguez <federico.rodriguez@wazuh.com> (cherry picked from commit 1398452)
Description
Removed obsolete code that caused duplicate requests to the api, and change the query to search for 1 agent.
Issues Resolved
Evidence
Details
Test
Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable
UI
management/configuration
are not repeatedGET /agents?agents_list=000
and does not have the parameterq
Details
⚫ Ensure that requests in management/configuration are not repeated
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ Check that the request to agents is like this GET /agents?agents_list=000 and does not have the parameter q
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
Check List
yarn test:jest