Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 5485 to 4.5 7.10] Remove deprecated code and request in Management #5550

Merged
merged 2 commits into from
Jun 13, 2023

Conversation

yenienserrano
Copy link
Member

Backport 1398452 from #5485.

* Remove deprecated code and request

* Add changelog

* Update snapshot

* remove: remove clusterStatus unused variable

* Remove clusterStatus property in groups-main.test.tsx

---------

Co-authored-by: Antonio David Gutiérrez <antonio.gutierrez@wazuh.com>
Co-authored-by: Federico Rodriguez <federico.rodriguez@wazuh.com>
(cherry picked from commit 1398452)
@yenienserrano yenienserrano requested a review from a team as a code owner June 12, 2023 11:00
@yenienserrano yenienserrano linked an issue Jun 12, 2023 that may be closed by this pull request
12 tasks
@yenienserrano yenienserrano linked an issue Jun 12, 2023 that may be closed by this pull request
@github-actions
Copy link
Contributor

Code coverage (Jest) % values
Statements 9.55% ( 3519 / 36852 )
Branches 5.02% ( 1433 / 28568 )
Functions 8.24% ( 752 / 9130 )
Lines 9.63% ( 3399 / 35297 )

Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review

code 🟢
test 🟢

Test

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

UI

Test Chrome Firefox Safari
Ensure that requests in management/configuration are not repeated 🟢
Check that the request to agents is like this GET /agents?agents_list=000 and does not have the parameter q 🟢

Details

🟢 Ensure that requests in management/configuration are not repeated

Chrome - 🟢
image
image
image

Firefox - ⚫

Safari - ⚫

🟢 Check that the request to agents is like this GET /agents?agents_list=000 and does not have the parameter q

Chrome - 🟢
image

Firefox - ⚫

Safari - ⚫

@AlexRuiz7 AlexRuiz7 merged commit 0ca58e2 into 4.5-7.10 Jun 13, 2023
@AlexRuiz7 AlexRuiz7 deleted the backport-5485-to-4.5-7.10 branch June 13, 2023 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wazuh API usage - Management/Configuration
3 participants