Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the register agent selected cluster/manager config endpoint #6213

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Fix the register agent selected cluster/manager config endpoint #6213

merged 2 commits into from
Dec 13, 2023

Conversation

asteriscos
Copy link
Member

Description

This pull request fixes the conditional in the register agent service to determine if the app is in cluster mode or not.

Issues Resolved

This is part of the issue #6203

Test

The requests made to get the node configuration must match the cluster or manager configuration.

  • Configure the app in cluster mode
    • Go to modules > Overview and check no error toasts pop up
    • Go to Agents and check no error toasts pop up
  • Configure the app in manager mode
    • Go to modules > Overview and check no error toasts pop up
    • Go to Agents and check no error toasts pop up

image

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@asteriscos asteriscos requested a review from a team as a code owner December 13, 2023 18:38
@asteriscos asteriscos self-assigned this Dec 13, 2023
@asteriscos asteriscos linked an issue Dec 13, 2023 that may be closed by this pull request
Change the endpoint to get Wazuh manager auth configuration #6203
Closed
@github-actions GitHub Actions
Copy link
Contributor

Code coverage (Jest) % values
Statements 11.73% ( 4048 / 34505 )
Branches 7.96% ( 1855 / 23299 )
Functions 11.26% ( 930 / 8257 )
Lines 11.91% ( 3937 / 33045 )

@lucianogorza
Copy link
Contributor

lucianogorza commented Dec 13, 2023 •
edited
Loading

CR ✅

Test ✅

Cluster mode

Overview

image

Agents

image

Manager mode

Overview

image

Agents

image

LGTM

Machi3mfl
Machi3mfl approved these changes Dec 13, 2023
View reviewed changes
Copy link
Member

@Machi3mfl Machi3mfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✅
Test: ✅

Manager mode

Screenshot 2023-12-13 at 16 30 02 Screenshot 2023-12-13 at 16 30 44

Cluster mode

Screenshot 2023-12-13 at 16 40 16 Screenshot 2023-12-13 at 16 40 31

@asteriscos asteriscos merged commit 192c107 into 4.7.2 Dec 13, 2023
2 checks passed
@asteriscos asteriscos deleted the fix/fix-change-cluster-auth-request-6203 branch December 13, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucianogorza lucianogorza lucianogorza approved these changes

@Machi3mfl Machi3mfl Machi3mfl approved these changes

Assignees

@asteriscos asteriscos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change the endpoint to get Wazuh manager auth configuration
3 participants
@asteriscos @lucianogorza @Machi3mfl