Remove groups.js angular controller #6543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TestUI
Details 🟢 Create and delete groupsChrome - 🟢 Firefox - ⚫ Safari - ⚫ 🟢 Check group detail pageChrome - 🟢 Firefox - ⚫ Safari - ⚫ 🟢 Go to group detail -> Manage agents: Add and remove agentsChrome - 🟢 Firefox - ⚫ Safari - ⚫ |
JuanGarriuz
approved these changes
Mar 22, 2024
There was a problem hiding this comment.
LGTM!!
CR ✔️
Test ✔️
Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable
UI
| Test | Chrome | Firefox | Safari |
|---|---|---|---|
| Create and delete groups | 🟢 | ⚫ | ⚫ |
| Check group detail page | 🟢 | ⚫ | ⚫ |
| Go to group detail -> Manage agents: Add and remove agents | 🟢 | ⚫ | ⚫ |
Details
🟢 Create and delete groups
Chrome - 🟢
Firefox - ⚫
Safari - ⚫
🟢 Check group detail page
Chrome - 🟢
Firefox - ⚫
Safari - ⚫
🟢 Go to group detail -> Manage agents: Add and remove agents
Chrome - 🟢
Firefox - ⚫
Safari - ⚫
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request removes the AngularJS controller for manage groups.
Issues Resolved
#6540
Evidence
groups.webm
Test
Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable
UI
Details
⚫ Create and delete groups
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ Check group detail page
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ Go to group detail -> Manage agents: Add and remove agents
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
Check List
yarn test:jest