Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce overview welcome font size #6627

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

asteriscos
Copy link
Member

@asteriscos asteriscos commented Apr 26, 2024

Description

This PR reduces the size of the overview home page.

Issues Resolved

Closes #6624

Evidence

image

Test

  • Go to overview home
  • Verify:
    • KPI's title font size is 17.5px
    • KPI's description font size is 12px
    • Modules Card title is 16px
    • Modules Card content is 12px

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@asteriscos asteriscos self-assigned this Apr 26, 2024
@asteriscos asteriscos linked an issue Apr 26, 2024 that may be closed by this pull request
jbiset
jbiset previously approved these changes Apr 26, 2024
Copy link
Member

@jbiset jbiset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: 🟢

Test UI 🟢

Evidence

KPI's title font size is 17.5px

image

KPI's description font size is 12px

image

Modules Card title is 16px

image

Modules Card content is 12px

image

@Desvelao
Copy link
Member

Test 🟢

image

@Desvelao
Copy link
Member

Should this pull request add an entry into the changelog? I am not sure if not including the entry is intentional or not.

Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Desvelao Desvelao merged commit 979db9d into 4.8.0 Apr 29, 2024
1 check passed
@Desvelao Desvelao deleted the fix/overview-cards-font-size-too-big-6624 branch April 29, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Home overview cards font size is too big
3 participants