Upgrade reports before caching #2979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change will reduces upgrades, since `report.Upgrade` only performs an upgrade if necessary.
rbruggem
force-pushed
the
cache-upgraded-reports
branch
from
50d039a to
00a7f6c
Compare
Upgrading reports individually reduces the amount of upgrades, since some reports might have been upgraded in previously.
rbruggem
force-pushed
the
cache-upgraded-reports
branch
from
00a7f6c to
10f3e4c
Compare
rade
approved these changes
Dec 12, 2017
rade
added a commit
that referenced
this pull request
Dec 24, 2017
Since #2979 upgrading happens prior to merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will reduces upgrades, since
report.Upgradeonly performs an upgrade if necessary.Fixes #2970