Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipeline promotions designs #76

Merged
merged 53 commits into from
Oct 28, 2022
Merged

Pipeline promotions designs #76

merged 53 commits into from
Oct 28, 2022

Conversation

yiannistri
Copy link
Contributor

@yiannistri yiannistri commented Sep 21, 2022

@enekofb enekofb force-pushed the promotions-comparison branch from 235c299 to bb0dc4a Compare September 26, 2022 13:06
@enekofb enekofb force-pushed the promotions-comparison branch from 914c685 to fb57569 Compare September 26, 2022 13:45
@enekofb enekofb changed the title Promotions comparison Pipeline promotions Oct 6, 2022
@enekofb enekofb requested a review from a team October 7, 2022 07:57
@enekofb enekofb changed the title Pipeline promotions Pipeline promotions designs Oct 7, 2022

## Summary

Given a continuous delivery pipeline, the application goes via different environments in its way to production. We
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From @pfcurtis

The second option would be more broadly applicable now, as many of the prospects we have already have CI pipelines in place. To have a callback to their CI when the application is deployed would be easy to implement with most any CI tooling.

The first option would require some thinking ... especially around staged deployments or flagger rollouts. I think it would be potentially harder to rollback, if a problem occurs. Just my 2¢

kind: HelmRelease
name: podinfo
promotion:
pullRequest:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extend the spec to have a configurable strategy on how to handle multiple PRs not merged

@makkes @sympatheticmoose

Copy link
Contributor Author

@yiannistri yiannistri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@enekofb enekofb self-requested a review October 25, 2022 08:56
Copy link
Contributor

@enekofb enekofb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved as proxy of @yiannistri

enekofb and others added 3 commits October 25, 2022 12:05
Co-authored-by: Yiannis <8741709+yiannistri@users.noreply.github.com>
Co-authored-by: Yiannis <8741709+yiannistri@users.noreply.github.com>
docs/rfcs/0003-pipelines-promotion/README.md Outdated Show resolved Hide resolved
docs/rfcs/0003-pipelines-promotion/README.md Outdated Show resolved Hide resolved
docs/rfcs/0003-pipelines-promotion/README.md Outdated Show resolved Hide resolved
docs/rfcs/0003-pipelines-promotion/README.md Show resolved Hide resolved
docs/rfcs/0003-pipelines-promotion/README.md Show resolved Hide resolved
docs/rfcs/0003-pipelines-promotion/README.md Outdated Show resolved Hide resolved
docs/rfcs/0003-pipelines-promotion/README.md Outdated Show resolved Hide resolved
enekofb and others added 6 commits October 26, 2022 16:53
Co-authored-by: Max Jonas Werner <makkes@users.noreply.github.com>
Co-authored-by: Max Jonas Werner <makkes@users.noreply.github.com>
Co-authored-by: Max Jonas Werner <makkes@users.noreply.github.com>
Co-authored-by: Max Jonas Werner <makkes@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

promotions RFC and ADR
5 participants