-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pipeline promotions designs #76
Conversation
235c299
to
bb0dc4a
Compare
914c685
to
fb57569
Compare
|
||
## Summary | ||
|
||
Given a continuous delivery pipeline, the application goes via different environments in its way to production. We |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From @pfcurtis
The second option would be more broadly applicable now, as many of the prospects we have already have CI pipelines in place. To have a callback to their CI when the application is deployed would be easy to implement with most any CI tooling.
The first option would require some thinking ... especially around staged deployments or flagger rollouts. I think it would be potentially harder to rollback, if a problem occurs. Just my 2¢
kind: HelmRelease | ||
name: podinfo | ||
promotion: | ||
pullRequest: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extend the spec to have a configurable strategy on how to handle multiple PRs not merged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
docs/rfcs/0003-pipelines-promotion/detect-deployment-changes.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved as proxy of @yiannistri
Co-authored-by: Yiannis <8741709+yiannistri@users.noreply.github.com>
Co-authored-by: Yiannis <8741709+yiannistri@users.noreply.github.com>
Co-authored-by: Max Jonas Werner <makkes@users.noreply.github.com>
Co-authored-by: Max Jonas Werner <makkes@users.noreply.github.com>
Co-authored-by: Max Jonas Werner <makkes@users.noreply.github.com>
Co-authored-by: Max Jonas Werner <makkes@users.noreply.github.com>
closes weaveworks/weave-gitops-enterprise#1614