Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

make weavedns the name resolver for containers by default #383

Closed
rade opened this issue Feb 2, 2015 · 6 comments
Closed

make weavedns the name resolver for containers by default #383

rade opened this issue Feb 2, 2015 · 6 comments

Comments

@rade
Copy link
Member

rade commented Feb 2, 2015

Right now, containers started with weave run only use weavedns for name resolution when the --with-dns option has been specified. We did that because weavedns used to lack some key features required to act as a nameserver in a fair few cases. That has changed now, and hence that choice should be inverted, i.e. we should have a --without-dns option, though, arguably, only after #382.

NB: we'd want to avoid an ordering dependency here; i.e. it should be possible to start containers with dns pointing at weavedns even when weave/weavedns isn't running.

@rade rade added the feature label Feb 2, 2015
@squaremo
Copy link
Contributor

squaremo commented Feb 3, 2015

NB: we'd want to avoid an ordering dependency here; i.e. it should be possible to start containers with dns pointing at weavedns even when weave/weavedns isn't running.

One way to do that is to check whether it's running, and run it if not. Are there other ways?

@rade
Copy link
Member Author

rade commented Feb 3, 2015

One way to do that is to check whether it's running, and run it if not.

We don't do that for weave.

Are there other ways?

I want to preserve what is possible now; there is nothing stopping you from weave run --with-dnsing a container when neither weave or weavedns are running.

@rade rade added this to the next milestone May 28, 2015
@peterbourgon
Copy link
Contributor

+1

@rade
Copy link
Member Author

rade commented Jun 6, 2015

it should be possible to start containers with dns pointing at weavedns even when weave/weavedns isn't running.

While that is possible currently, doing so by default strikes me as dangerous; seems way to easy to accidentally start containers pointing at a non-existing (and never-to-exist) weavedns server.

So, how about the default behaviour is to point at weavedns if it is running. And have --with-dns and --without-dns options to override that choice.

The proxy's behaviour should be changed to match.

@rade rade changed the title [dns] make weavedns the name resolver for containers by default make weavedns the name resolver for containers by default Jun 6, 2015
@inercia
Copy link
Contributor

inercia commented Jun 9, 2015

Should this issue be solved after #382? If so, I guess #382 should have the same milestone...

@rade
Copy link
Member Author

rade commented Jun 9, 2015

Should this issue be solved after #382?

No.

@awh awh self-assigned this Jun 11, 2015
@awh awh assigned paulbellamy and unassigned awh Jun 16, 2015
@rade rade closed this as completed in #898 Jun 16, 2015
rade added a commit that referenced this issue Jun 16, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants