Skip to content
This repository was archived by the owner on Jun 20, 2024. It is now read-only.

Do not exclude k8s node without any IP addr in reclaim #3393

Merged
merged 1 commit into from
Sep 6, 2018

Conversation

brb
Copy link
Contributor

@brb brb commented Sep 4, 2018

Otherwise, such node will be rmpeer'd which can lead to the IPAM inconsistencies "Received update for IP range I own at <..>".

Fix #3392 and maybe #3310.

@brb brb added this to the 2.5 milestone Sep 4, 2018
Copy link
Contributor

@bboreham bboreham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "design" of this tool is starting to creak, but this change looks ok in context.

@bboreham
Copy link
Contributor

bboreham commented Sep 5, 2018

Should this be on the 2.4 branch?

Otherwise, such node will be rmpeer'd which can lead to the IPAM
inconsistencies "Received update for IP range I own at <..>".
@brb brb force-pushed the issues/3392-get-peers-with-no-ip branch from 04ee0de to acc24f1 Compare September 6, 2018 11:50
@brb brb changed the base branch from master to 2.4 September 6, 2018 11:51
@brb brb modified the milestones: 2.5, 2.4.1 Sep 6, 2018
@brb
Copy link
Contributor Author

brb commented Sep 6, 2018

Changed the base branch to 2.4.

@bboreham bboreham merged commit fc211b1 into 2.4 Sep 6, 2018
@bboreham bboreham deleted the issues/3392-get-peers-with-no-ip branch December 24, 2018 12:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants