This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
Add proxy info to 'weave status' output #800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
which is more standard with others, and doesn't conflict with docker api
|
Example output is: |
rade
changed the title
rade
added a commit
that referenced
this pull request
May 29, 2015
Add proxy info to 'weave status' output Closes #756.
rade
added a commit
to rade/weave
that referenced
this pull request
Jun 8, 2015
There are two problems with obtaining the proxy status via the normal proxy endpoint... 1. when TLS is enabled, this requires using TLS at the client end 2. the status URL is mixed in with the docker remote API, which is rather unclean There is limited value to having some status output from the proxy, since all the output is constant. So instead we log the version and command line args. We still want a way to wait for the proxy to start up, and log a nice error if it dies. We do this by polling the docker logs for a startup message. Fixes weaveworks#877. Fixes weaveworks#876. Undoes weaveworks#756, weaveworks#800, weaveworks#854.
rade
added a commit
to rade/weave
that referenced
this pull request
Jun 9, 2015
There are two problems with obtaining the proxy status via the normal proxy endpoint... 1. when TLS is enabled, this requires using TLS at the client end 2. the status URL is mixed in with the docker remote API, which is rather unclean There is limited value to having some status output from the proxy, since all the output is constant. So instead we log the version and command line args. We still want a way to wait for the proxy to start up, and log a nice error if it dies. We do this by polling the docker logs for a startup message. Fixes weaveworks#877. Fixes weaveworks#876. Undoes weaveworks#756, weaveworks#800, weaveworks#854.
rade
added a commit
to rade/weave
that referenced
this pull request
Jun 9, 2015
There are two problems with obtaining the proxy status via the normal proxy endpoint... 1. when TLS is enabled, this requires using TLS at the client end 2. the status URL is mixed in with the docker remote API, which is rather unclean There is limited value to having some status output from the proxy, since all the output is constant. So instead we log the version and command line args. We still want a way to wait for the proxy to start up, and log a nice error if it dies. We do this by polling the docker logs for a startup message. Fixes weaveworks#877. Fixes weaveworks#876. Undoes weaveworks#756, weaveworks#800, weaveworks#854.
rade
added a commit
to rade/weave
that referenced
this pull request
Jun 9, 2015
There are two problems with obtaining the proxy status via the normal proxy endpoint... 1. when TLS is enabled, this requires using TLS at the client end 2. the status URL is mixed in with the docker remote API, which is rather unclean There is limited value to having some status output from the proxy, since all the output is constant. So instead we log the version and command line args. We still want a way to wait for the proxy to start up, and log a nice error if it dies. We do this by polling the docker logs for a startup message. Fixes weaveworks#877. Fixes weaveworks#876. Undoes weaveworks#756, weaveworks#800, weaveworks#854.
rade
added a commit
to rade/weave
that referenced
this pull request
Jun 9, 2015
There are two problems with obtaining the proxy status via the normal proxy endpoint... 1. when TLS is enabled, this requires using TLS at the client end 2. the status URL is mixed in with the docker remote API, which is rather unclean There is limited value to having some status output from the proxy, since all the output is constant. So instead we log the version and command line args, and in `weave status` only report whether the proxy is running. We still want a way to wait for the proxy to start up, and log a nice error if it dies. We do this by polling the docker logs for a startup message. Fixes weaveworks#877. Fixes weaveworks#876. Undoes most of weaveworks#756, weaveworks#800, weaveworks#854.
rade
added a commit
to rade/weave
that referenced
this pull request
Jun 9, 2015
There are two problems with obtaining the proxy status via the normal proxy endpoint... 1. when TLS is enabled, this requires using TLS at the client end 2. the status URL is mixed in with the docker remote API, which is rather unclean There is limited value to having some status output from the proxy, since all the output is constant. So instead we log the version and command line args, and in `weave status` only report whether the proxy is running. We still want a way to wait for the proxy to start up, and log a nice error if it dies. We do this by polling the docker logs for a startup message. Fixes weaveworks#877. Fixes weaveworks#876. Undoes most of weaveworks#756, weaveworks#800, weaveworks#854.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #756