Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

remove most of proxy status #878

Merged
merged 1 commit into from
Jun 9, 2015

Conversation

rade
Copy link
Member

@rade rade commented Jun 8, 2015

There are two problems with obtaining the proxy status via the normal
proxy endpoint...

  1. when TLS is enabled, this requires using TLS at the client end
  2. the status URL is mixed in with the docker remote API, which is
    rather unclean

There is limited value to having some status output from the proxy,
since all the output is constant.

So instead we log the version and command line args.

We still want a way to wait for the proxy to start up, and log a nice
error if it dies. We do this by polling the docker logs for a startup
message.

Fixes #877. Fixes #876.

Undoes #756, #800, #854.

@rade
Copy link
Member Author

rade commented Jun 8, 2015

I am not sure about this one. It would be nice to have a proxy status. But not when we have to jump through hoops as in #875.

One possible improvement here is that we could report in weave status that the proxy is running.

@rade rade force-pushed the 877_remove_proxy_status branch 2 times, most recently from 1fb2115 to 6e30c9c Compare June 9, 2015 08:54
@paulbellamy
Copy link
Contributor

It is nice for debugging to just say "Please send us weave status", so having the proxy config output as part of it is handy. Checking the container is running, then grabbing the status output from the logs is probably a reasonable compromise (either CLI flags, or formatted as now).

@rade rade force-pushed the 877_remove_proxy_status branch from 6e30c9c to 19a13c6 Compare June 9, 2015 10:07
@rade rade assigned rade and unassigned paulbellamy Jun 9, 2015
@rade rade force-pushed the 877_remove_proxy_status branch from eebd7d6 to 989be4a Compare June 9, 2015 10:43
@rade rade changed the title remove proxy status remove most of proxy status Jun 9, 2015
@rade
Copy link
Member Author

rade commented Jun 9, 2015

I've added a line to weave status when the proxy is running.

Processing the docker logs and extracing readable status output is quite horrible, so I didn't do that.

@rade rade assigned paulbellamy and unassigned rade Jun 9, 2015
wait_for_log() {
fifo=/tmp/tmpfifo.$$
mkfifo $fifo || exit 1
docker logs -f $1 2>/dev/null >$fifo &

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

@rade rade assigned rade and unassigned paulbellamy Jun 9, 2015
There are two problems with obtaining the proxy status via the normal
proxy endpoint...

1. when TLS is enabled, this requires using TLS at the client end

2. the status URL is mixed in with the docker remote API, which is
rather unclean

There is limited value to having some status output from the proxy,
since all the output is constant.

So instead we log the version and command line args, and in `weave
status` only report whether the proxy is running.

We still want a way to wait for the proxy to start up, and log a nice
error if it dies. We do this by polling the docker logs for a startup
message.

Fixes weaveworks#877. Fixes weaveworks#876.

Undoes most of weaveworks#756, weaveworks#800, weaveworks#854.
@rade rade force-pushed the 877_remove_proxy_status branch from 989be4a to fee2898 Compare June 9, 2015 13:03
@rade rade assigned paulbellamy and unassigned rade Jun 9, 2015
paulbellamy added a commit that referenced this pull request Jun 9, 2015
@paulbellamy paulbellamy merged commit 03fa95f into weaveworks:master Jun 9, 2015
@rade rade modified the milestone: 1.0 Jun 9, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants