-
Notifications
You must be signed in to change notification settings - Fork 670
Conversation
I am not sure about this one. It would be nice to have a proxy status. But not when we have to jump through hoops as in #875. One possible improvement here is that we could report in |
1fb2115
to
6e30c9c
Compare
It is nice for debugging to just say "Please send us |
6e30c9c
to
19a13c6
Compare
eebd7d6
to
989be4a
Compare
I've added a line to Processing the docker logs and extracing readable status output is quite horrible, so I didn't do that. |
wait_for_log() { | ||
fifo=/tmp/tmpfifo.$$ | ||
mkfifo $fifo || exit 1 | ||
docker logs -f $1 2>/dev/null >$fifo & |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
There are two problems with obtaining the proxy status via the normal proxy endpoint... 1. when TLS is enabled, this requires using TLS at the client end 2. the status URL is mixed in with the docker remote API, which is rather unclean There is limited value to having some status output from the proxy, since all the output is constant. So instead we log the version and command line args, and in `weave status` only report whether the proxy is running. We still want a way to wait for the proxy to start up, and log a nice error if it dies. We do this by polling the docker logs for a startup message. Fixes weaveworks#877. Fixes weaveworks#876. Undoes most of weaveworks#756, weaveworks#800, weaveworks#854.
989be4a
to
fee2898
Compare
remove most of proxy status
There are two problems with obtaining the proxy status via the normal
proxy endpoint...
rather unclean
There is limited value to having some status output from the proxy,
since all the output is constant.
So instead we log the version and command line args.
We still want a way to wait for the proxy to start up, and log a nice
error if it dies. We do this by polling the docker logs for a startup
message.
Fixes #877. Fixes #876.
Undoes #756, #800, #854.