Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm repositories #21

Merged
merged 2 commits into from
Jul 4, 2023
Merged

Helm repositories #21

merged 2 commits into from
Jul 4, 2023

Conversation

bigkevmcd
Copy link
Collaborator

This adds support for Helm Repositories in the view.

It also tidies up the response type and adds additional documentation.

@bigkevmcd bigkevmcd requested a review from foot July 4, 2023 11:28
@@ -42,6 +47,8 @@ yarn add --cwd packages/app @weaveworksoss/backstage-plugin-flux

## Configuration

The Flux plugins provide several different Cards, which are composable into your Backstage App.

1. Add the card to your app EntityPage.tsx

```tsx
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add helmrepo to entitypage here too


If you have [Weave GitOps](https://www.weave.works/product/gitops/) or [Weave GitOps Enterprise](https://www.weave.works/product/gitops-enterprise/) you can configure the plugins to link through to the UI which will provide more information on the resources.

This will generate link URLs through to the relevant UIs relative to the configured URL, for example to view Helm Repositories, this would generate a URL that looks like this `https://wego.example.com/wego/helm_repo/details?clusterName=demo-cluster&name=podinfo&namespace=default`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

Wrapper = ({ children }: { children?: React.ReactNode }) => (
<div>{children}</div>
);
});
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe don't need wrapper anymore?

OCIRepository,
} from '../objects';
import Flex from './Flex';
import KubeStatusIndicator, { getIndicatorInfo } from './KubeStatusIndicator';

export type Source = GitRepository | OCIRepository | HelmRepository;
export type Deployment = HelmRelease;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🧹

This is a new Card that displays HelmRepositories.
@bigkevmcd bigkevmcd merged commit 3280df1 into main Jul 4, 2023
1 check passed
@bigkevmcd bigkevmcd deleted the helm-repositories branch July 4, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants