Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for object deletion conflict resolution #1307

Merged
merged 7 commits into from
Oct 8, 2024

Conversation

dirkkul
Copy link
Collaborator

@dirkkul dirkkul commented Sep 17, 2024

No description provided.

@dirkkul dirkkul marked this pull request as draft September 17, 2024 11:38
@dirkkul dirkkul force-pushed the propagateObjectDeletion branch from eb362d0 to 7e7d8e0 Compare October 1, 2024 16:22
@dirkkul dirkkul marked this pull request as ready for review October 1, 2024 16:24
@dirkkul dirkkul requested a review from a team as a code owner October 1, 2024 16:24
@dirkkul dirkkul force-pushed the propagateObjectDeletion branch 2 times, most recently from 4e7170c to 1da2e44 Compare October 4, 2024 10:02
@dirkkul dirkkul force-pushed the propagateObjectDeletion branch from 1da2e44 to 83f8b98 Compare October 8, 2024 07:42
@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.38%. Comparing base (624e2e2) to head (e72ce95).
Report is 66 commits behind head on main.

Files with missing lines Patch % Lines
integration/test_collection_config.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1307      +/-   ##
==========================================
- Coverage   94.38%   94.38%   -0.01%     
==========================================
  Files         220      220              
  Lines       20953    20965      +12     
==========================================
+ Hits        19776    19787      +11     
- Misses       1177     1178       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dirkkul dirkkul changed the title Add support for feat_objdel_propagation Add support for object deletion conflict resolution Oct 8, 2024
@dirkkul dirkkul merged commit 2d53c8f into main Oct 8, 2024
49 of 50 checks passed
@dirkkul dirkkul deleted the propagateObjectDeletion branch October 8, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants