Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve throughput and resiliency of batching algo #1371

Closed
wants to merge 8 commits into from
Closed

Improve throughput and resiliency of batching algo #1371

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
89c65c8
Improve throughput and resiliency of batching algo:
tsmith023 Oct 29, 2024
f554d45
Ensure awaited coro's raised exception can be caught properly
tsmith023 Oct 30, 2024
242ca87
Ensure all futures are handled in all casesof the batch send loop
tsmith023 Oct 30, 2024
a52e812
Uncomment commented-out test code
tsmith023 Oct 30, 2024
6144bfe
Merge branch 'main' of https://github.com/weaviate/weaviate-python-cl…
tsmith023 Oct 30, 2024
c58114e
Add error logging to thread exception catching
tsmith023 Oct 30, 2024
6b876ba
Move as_completed inside batch context to avoid races
tsmith023 Oct 30, 2024
a12c055
Attempt race avoidance while flushing batch
tsmith023 Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions integration/test_batch_v4.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -553,9 +553,9 @@ def test_add_1000_tenant_objects_with_async_indexing_and_wait_for_only_one(
lambda client: client.batch.rate_limit(1000),
],
ids=[
"test_add_one_hundred_objects_and_references_between_all_dynamic",
"test_add_one_hundred_objects_and_references_between_all_fixed_size",
"test_add_one_hundred_objects_and_references_between_all_rate_limit",
"test_add_one_object_and_a_self_reference_dynamic",
"test_add_one_object_and_a_self_reference_fixed_size",
"test_add_one_object_and_a_self_reference_rate_limit",
],
)
def test_add_one_object_and_a_self_reference(
Expand Down Expand Up @@ -596,8 +596,8 @@ def batch_insert(batch: BatchClient) -> None:
with concurrent.futures.ThreadPoolExecutor() as executor:
with client.batch.dynamic() as batch:
futures = [executor.submit(batch_insert, batch) for _ in range(nr_threads)]
for future in concurrent.futures.as_completed(futures):
future.result()
for future in concurrent.futures.as_completed(futures):
future.result()
objs = client.collections.get(name).query.fetch_objects(limit=nr_objects * nr_threads).objects
assert len(objs) == nr_objects * nr_threads

Expand Down
Loading