fix: falsy rule should not pass the validation (#8297)

packages/rspack-test-tools/tests/configCases/module/falsy/index.js

@@ -0,0 +1,8 @@
+import { lib, lib1 } from "./lib";
+
+it("`oneOf` should work", () => {
+	// should run loader & loader2 and not run loader1
+	expect(lib).toEqual("aabc");
+
+	expect(lib1).toEqual("effg");
+});

packages/rspack-test-tools/tests/configCases/module/falsy/lib.js

@@ -0,0 +1,3 @@
+export const lib = "abc";
+
+export const lib1 = "efg";

packages/rspack-test-tools/tests/configCases/module/falsy/loader.js

@@ -0,0 +1,3 @@
+module.exports = function (content) {
+	this.callback(null, content.replace("ab", "aab"));
+};

packages/rspack-test-tools/tests/configCases/module/falsy/loader1.js

@@ -0,0 +1,3 @@
+module.exports = function (content) {
+	this.callback(null, content.replace("bc", "bcc"));
+};

packages/rspack-test-tools/tests/configCases/module/falsy/loader2.js

@@ -0,0 +1,3 @@
+module.exports = function (content) {
+	this.callback(null, content.replace("ef", "eff"));
+};

packages/rspack-test-tools/tests/configCases/module/falsy/rspack.config.js

@@ -0,0 +1,31 @@
+/**
+ * @type {import('@rspack/core').RspackOptions}
+ */
+module.exports = {
+	context: __dirname,
+	module: {
+		rules: [
+			undefined,
+			{
+				test: /lib.js/,
+				use: ["./loader2.js"]
+			},
+			{
+				test: /lib.js/,
+				oneOf: [
+					undefined,
+					{
+						resourceQuery: "/(__inline=false|url)/",
+						use: ["./loader1.js"]
+					},
+					{
+						use: ["./loader.js"]
+					},
+					{
+						use: ["./loader1.js"]
+					}
+				]
+			}
+		]
+	}
+};

packages/rspack/etc/core.api.md

@@ -9316,8 +9316,8 @@ export type RuleSetRule = {
     resolve?: ResolveOptions;
     sideEffects?: boolean;
     enforce?: "pre" | "post";
-    oneOf?: RuleSetRule[];
-    rules?: RuleSetRule[];
+    oneOf?: (RuleSetRule | Falsy)[];
+    rules?: (RuleSetRule | Falsy)[];
 };
 
 // @public

packages/rspack/src/config/adapter.ts

@@ -460,24 +460,28 @@ const getRawModuleRule = (
 			: undefined,
 		resolve: rule.resolve ? getRawResolve(rule.resolve) : undefined,
 		oneOf: rule.oneOf
-			? rule.oneOf.map((rule, index) =>
-					getRawModuleRule(
-						rule,
-						`${path}.oneOf[${index}]`,
-						options,
-						rule.type ?? upperType
+			? rule.oneOf
+					.filter(Boolean)
+					.map((rule, index) =>
+						getRawModuleRule(
+							rule as RuleSetRule,
+							`${path}.oneOf[${index}]`,
+							options,
+							(rule as RuleSetRule).type ?? upperType
+						)
 					)
-				)
 			: undefined,
 		rules: rule.rules
-			? rule.rules.map((rule, index) =>
-					getRawModuleRule(
-						rule,
-						`${path}.rules[${index}]`,
-						options,
-						rule.type ?? upperType
+			? rule.rules
+					.filter(Boolean)
+					.map((rule, index) =>
+						getRawModuleRule(
+							rule as RuleSetRule,
+							`${path}.rules[${index}]`,
+							options,
+							(rule as RuleSetRule).type ?? upperType
+						)
 					)
-				)
 			: undefined,
 		enforce: rule.enforce
 	};

packages/rspack/src/config/types.ts

@@ -897,10 +897,10 @@ export type RuleSetRule = {
 	enforce?: "pre" | "post";
 
 	/** A kind of Nested Rule, an array of Rules from which only the first matching Rule is used when the parent Rule matches. */
-	oneOf?: RuleSetRule[];
+	oneOf?: (RuleSetRule | Falsy)[];
 
 	/** A kind of Nested Rule, an array of Rules that is also used when the parent Rule matches. */
-	rules?: RuleSetRule[];
+	rules?: (RuleSetRule | Falsy)[];
 };
 
 /** A list of rules. */

packages/rspack/src/config/zod.ts

@@ -484,8 +484,8 @@ const baseRuleSetRule = z.strictObject({
 }) satisfies z.ZodType<t.RuleSetRule>;
 
 const ruleSetRule: z.ZodType<t.RuleSetRule> = baseRuleSetRule.extend({
-	oneOf: z.lazy(() => ruleSetRule.array()).optional(),
-	rules: z.lazy(() => ruleSetRule.array()).optional()
+	oneOf: z.lazy(() => ruleSetRule.or(falsy).array()).optional(),
+	rules: z.lazy(() => ruleSetRule.or(falsy).array()).optional()
 });
 
 const ruleSetRules = z.array(

website/docs/en/config/module.mdx

@@ -705,7 +705,7 @@ Same as [`module.generator["css/auto"].esModule`](#modulegeneratorcssautoesmodul
 
 ## module.rules
 
-- **Type:** `Rule[]`
+- **Type:** `(Rule | Falsy)[]`
 - **Default:** `[]`
 
 An array of rules that match the module's requests when it is created. These rules can modify the creation behavior of the module. They can apply Loader, etc. to the module.
@@ -1223,7 +1223,7 @@ A kind of [Nested Rule](#nested-rule), an array of Rules that is also used when
 
 ### Rule.oneOf
 
-- **Type:** <code>[Rule](#rule)[]</code>
+- **Type:** <code>([Rule](#rule) | Falsy)[]</code>
 - **Default:** `undefined`
 
 A kind of [Nested Rule](#nested-rule), an array of Rules from which only the first matching Rule is used when the parent Rule matches.

website/docs/zh/config/module.mdx

@@ -13,7 +13,7 @@ import WebpackLicense from '@components/WebpackLicense';
 
 ## module.defaultRules
 
-- **类型：** `Rule[]`
+- **类型：** `(Rule | Falsy)[]`
 
 应用于模块的默认规则。
 
@@ -1221,7 +1221,7 @@ module.exports = {
 
 ### Rule.oneOf
 
-- **类型：** <code>[Rule](#rule)[]</code>
+- **类型：** <code>([Rule](#rule) | Falsy)[]</code>
 - **默认值：** `undefined`
 
 [嵌套 Rule](#nested-rule) 的一种，当其上层 Rule 匹配成功后会使用这些 Rule 进行匹配，并且只使用匹配成功的第一个 Rule