Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: falsy rule should be filtered #8297

Merged
merged 4 commits into from
Nov 1, 2024
Merged

fix: falsy rule should be filtered #8297

merged 4 commits into from
Nov 1, 2024

Conversation

LingyuCoder
Copy link
Contributor

@LingyuCoder LingyuCoder commented Oct 31, 2024

Summary

Close #8238

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added team The issue/pr is created by the member of Rspack. release: bug fix release: bug related release(mr only) labels Oct 31, 2024
Copy link

netlify bot commented Oct 31, 2024

Deploy Preview for rspack ready!

Name Link
🔨 Latest commit 24f4489
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/672487b26affee00085c13fc
😎 Deploy Preview https://deploy-preview-8297--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@LingyuCoder LingyuCoder enabled auto-merge (squash) October 31, 2024 11:22
@LingyuCoder LingyuCoder changed the title fix: falsy rule should not pass the validation fix: falsy rule should be filtered Nov 1, 2024
@LingyuCoder LingyuCoder merged commit 638b82f into main Nov 1, 2024
28 checks passed
@LingyuCoder LingyuCoder deleted the fix/rules-empty-type branch November 1, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: error is thrown when a value of undefined is encountered where loader is expected
2 participants