-
-
Notifications
You must be signed in to change notification settings - Fork 602
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
11 changed files
with
334 additions
and
208 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,108 +1,180 @@ | ||
| use std::{cell::RefCell, ptr::NonNull}; | ||
|
|
||
| use napi::bindgen_prelude::ToNapiValue; | ||
| use napi_derive::napi; | ||
| use rspack_core::{BoxDependency, DependencyId}; | ||
| use rspack_core::{Compilation, CompilationId, Dependency, DependencyId}; | ||
| use rspack_napi::OneShotRef; | ||
| use rustc_hash::FxHashMap as HashMap; | ||
|
|
||
| // JsDependency allows JS-side access to a Dependency instance that has already | ||
| // been processed and stored in the Compilation. | ||
| #[napi] | ||
| pub struct JsDependency(&'static BoxDependency); | ||
| pub struct JsDependency { | ||
| pub(crate) compilation: Option<NonNull<Compilation>>, | ||
| pub(crate) dependency_id: DependencyId, | ||
| pub(crate) dependency: NonNull<dyn Dependency>, | ||
| } | ||
|
|
||
| impl JsDependency { | ||
| pub(crate) fn new(dependency: &BoxDependency) -> Self { | ||
| // SAFETY: | ||
| // The lifetime of the &mut BoxDependency reference is extended to 'static. | ||
| // Accessing fields and methods on the Rust object from the JS side after the Rust object's | ||
| // lifetime has ended is undefined behavior, which we currently disregard. | ||
| let dependency = | ||
| unsafe { std::mem::transmute::<&BoxDependency, &'static BoxDependency>(dependency) }; | ||
| Self(dependency) | ||
| fn as_ref(&mut self) -> napi::Result<&dyn Dependency> { | ||
| if let Some(compilation) = self.compilation { | ||
| let compilation = unsafe { compilation.as_ref() }; | ||
| let module_graph = compilation.get_module_graph(); | ||
| if let Some(dependency) = module_graph.dependency_by_id(&self.dependency_id) { | ||
| self.dependency = { | ||
| #[allow(clippy::unwrap_used)] | ||
| NonNull::new(dependency.as_ref() as *const dyn Dependency as *mut dyn Dependency).unwrap() | ||
| }; | ||
| Ok(unsafe { self.dependency.as_ref() }) | ||
| } else { | ||
| Err(napi::Error::from_reason(format!( | ||
| "Unable to access dependency with id = {:?} now. The dependency have been removed on the Rust side.", | ||
| self.dependency_id | ||
| ))) | ||
| } | ||
| } else { | ||
| // SAFETY: | ||
| // We need to make users aware in the documentation that values obtained within the JS hook callback should not be used outside the scope of the callback. | ||
| // We do not guarantee that the memory pointed to by the pointer remains valid when used outside the scope. | ||
| Ok(unsafe { self.dependency.as_ref() }) | ||
| } | ||
| } | ||
|
|
||
| pub(crate) fn id(&self) -> &DependencyId { | ||
| self.0.id() | ||
| fn as_mut(&mut self) -> napi::Result<&mut dyn Dependency> { | ||
| // SAFETY: | ||
| // We need to make users aware in the documentation that values obtained within the JS hook callback should not be used outside the scope of the callback. | ||
| // We do not guarantee that the memory pointed to by the pointer remains valid when used outside the scope. | ||
| Ok(unsafe { self.dependency.as_mut() }) | ||
| } | ||
| } | ||
|
|
||
| #[napi] | ||
| impl JsDependency { | ||
| #[napi(getter)] | ||
| pub fn get_type(&self) -> &str { | ||
| self.0.dependency_type().as_str() | ||
| pub fn get_type(&mut self) -> napi::Result<&str> { | ||
| let dependency = self.as_ref()?; | ||
|
|
||
| Ok(dependency.dependency_type().as_str()) | ||
| } | ||
|
|
||
| #[napi(getter)] | ||
| pub fn category(&self) -> &str { | ||
| self.0.category().as_str() | ||
| pub fn category(&mut self) -> napi::Result<&str> { | ||
| let dependency = self.as_ref()?; | ||
|
|
||
| Ok(dependency.category().as_str()) | ||
| } | ||
|
|
||
| #[napi(getter)] | ||
| pub fn request(&self) -> napi::Either<&str, ()> { | ||
| match self.0.as_module_dependency() { | ||
| pub fn request(&mut self) -> napi::Result<napi::Either<&str, ()>> { | ||
| let dependency = self.as_ref()?; | ||
|
|
||
| Ok(match dependency.as_module_dependency() { | ||
| Some(dep) => napi::Either::A(dep.request()), | ||
| None => napi::Either::B(()), | ||
| } | ||
| }) | ||
| } | ||
|
|
||
| #[napi(getter)] | ||
| pub fn critical(&self) -> bool { | ||
| match self.0.as_context_dependency() { | ||
| pub fn critical(&mut self) -> napi::Result<bool> { | ||
| let dependency = self.as_ref()?; | ||
|
|
||
| Ok(match dependency.as_context_dependency() { | ||
| Some(dep) => dep.critical().is_some(), | ||
| None => false, | ||
| }) | ||
| } | ||
|
|
||
| #[napi(setter)] | ||
| pub fn set_critical(&mut self, val: bool) -> napi::Result<()> { | ||
| let dependency = self.as_mut()?; | ||
|
|
||
| if let Some(dep) = dependency.as_context_dependency_mut() { | ||
| let critical = dep.critical_mut(); | ||
| if !val { | ||
| *critical = None; | ||
| } | ||
| } | ||
| Ok(()) | ||
| } | ||
| } | ||
|
|
||
| // JsDependency represents a Dependency instance that is currently being processed. | ||
| // It is in the make stage and has not yet been added to the Compilation. | ||
| #[napi] | ||
| pub struct JsDependencyMut(&'static mut BoxDependency); | ||
| type DependencyInstanceRefs = HashMap<DependencyId, OneShotRef<JsDependency>>; | ||
|
|
||
| impl JsDependencyMut { | ||
| pub(crate) fn new(dependency: &mut BoxDependency) -> Self { | ||
| // SAFETY: | ||
| // The lifetime of the &mut BoxDependency reference is extended to 'static. | ||
| // Accessing fields and methods on the Rust object from the JS side after the Rust object's | ||
| // lifetime has ended is undefined behavior, which we currently disregard. | ||
| let dependency = | ||
| unsafe { std::mem::transmute::<&mut BoxDependency, &'static mut BoxDependency>(dependency) }; | ||
| Self(dependency) | ||
| } | ||
| type DependencyInstanceRefsByCompilationId = | ||
| RefCell<HashMap<CompilationId, DependencyInstanceRefs>>; | ||
|
|
||
| thread_local! { | ||
| static DEPENDENCY_INSTANCE_REFS: DependencyInstanceRefsByCompilationId = Default::default(); | ||
| } | ||
|
|
||
| #[napi] | ||
| impl JsDependencyMut { | ||
| #[napi(getter)] | ||
| pub fn get_type(&self) -> &str { | ||
| self.0.dependency_type().as_str() | ||
| } | ||
| pub struct JsDependencyWrapper { | ||
| dependency_id: DependencyId, | ||
| dependency: NonNull<dyn Dependency>, | ||
| compilation_id: CompilationId, | ||
| compilation: Option<NonNull<Compilation>>, | ||
| } | ||
|
|
||
| #[napi(getter)] | ||
| pub fn category(&self) -> &str { | ||
| self.0.category().as_str() | ||
| } | ||
| impl JsDependencyWrapper { | ||
| pub fn new( | ||
| dependency: &dyn Dependency, | ||
| compilation_id: CompilationId, | ||
| compilation: Option<&Compilation>, | ||
| ) -> Self { | ||
| let dependency_id = *dependency.id(); | ||
|
|
||
| #[napi(getter)] | ||
| pub fn request(&self) -> napi::Either<&str, ()> { | ||
| match self.0.as_module_dependency() { | ||
| Some(dep) => napi::Either::A(dep.request()), | ||
| None => napi::Either::B(()), | ||
| #[allow(clippy::unwrap_used)] | ||
| Self { | ||
| dependency_id, | ||
| dependency: NonNull::new(dependency as *const dyn Dependency as *mut dyn Dependency).unwrap(), | ||
| compilation_id, | ||
| compilation: compilation | ||
| .map(|c| NonNull::new(c as *const Compilation as *mut Compilation).unwrap()), | ||
| } | ||
| } | ||
|
|
||
| #[napi(getter)] | ||
| pub fn critical(&self) -> bool { | ||
| match self.0.as_context_dependency() { | ||
| Some(dep) => dep.critical().is_some(), | ||
| None => false, | ||
| } | ||
| pub fn cleanup_last_compilation(compilation_id: CompilationId) { | ||
| DEPENDENCY_INSTANCE_REFS.with(|refs| { | ||
| let mut refs_by_compilation_id = refs.borrow_mut(); | ||
| refs_by_compilation_id.remove(&compilation_id) | ||
| }); | ||
| } | ||
| } | ||
|
|
||
| #[napi(setter)] | ||
| pub fn set_critical(&mut self, val: bool) { | ||
| if let Some(dep) = self.0.as_context_dependency_mut() { | ||
| let critical = dep.critical_mut(); | ||
| if !val { | ||
| *critical = None; | ||
| impl ToNapiValue for JsDependencyWrapper { | ||
| unsafe fn to_napi_value( | ||
| env: napi::sys::napi_env, | ||
| val: Self, | ||
| ) -> napi::Result<napi::sys::napi_value> { | ||
| DEPENDENCY_INSTANCE_REFS.with(|refs| { | ||
| let mut refs_by_compilation_id = refs.borrow_mut(); | ||
| let entry = refs_by_compilation_id.entry(val.compilation_id); | ||
| let refs = match entry { | ||
| std::collections::hash_map::Entry::Occupied(entry) => entry.into_mut(), | ||
| std::collections::hash_map::Entry::Vacant(entry) => { | ||
| let refs = HashMap::default(); | ||
| entry.insert(refs) | ||
| } | ||
| }; | ||
|
|
||
| match refs.entry(val.dependency_id) { | ||
| std::collections::hash_map::Entry::Occupied(occupied_entry) => { | ||
| let r = occupied_entry.get(); | ||
| let instance = r.from_napi_mut_ref()?; | ||
| instance.compilation = val.compilation; | ||
| instance.dependency = val.dependency; | ||
|
|
||
| ToNapiValue::to_napi_value(env, r) | ||
| } | ||
| std::collections::hash_map::Entry::Vacant(vacant_entry) => { | ||
| let js_dependency = JsDependency { | ||
| compilation: val.compilation, | ||
| dependency_id: val.dependency_id, | ||
| dependency: val.dependency, | ||
| }; | ||
| let r = vacant_entry.insert(OneShotRef::new(env, js_dependency)?); | ||
| ToNapiValue::to_napi_value(env, r) | ||
| } | ||
| } | ||
| } | ||
| }) | ||
| } | ||
| } |
Oops, something went wrong.
78aa2e0There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 Benchmark detail: Open
78aa2e0There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 Ran ecosystem CI: Open