-
-
Notifications
You must be signed in to change notification settings - Fork 623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: unify js dependency #8394
Conversation
✅ Deploy Preview for rspack canceled.
|
!bench |
!eco-ci |
📝 Benchmark detail: Open
|
eb6991a
to
820826c
Compare
This pr depends on accessing a field within a raw pointer, for example
But I wonder if access id here will panic ? And this is a solution that relies on UB ? Can we accept this @h-a-n-a |
8acb83d
to
5b2e260
Compare
No, this will not panic and it's more likely a undefined behavior if the memory you're accessing to is freed and it will likely to cause segmentation faults. All we need to do is to prevent user from accessing that value after the scope is dropped. |
67e7e90
to
d9844db
Compare
d9844db
to
4162479
Compare
Summary
feat: unify js dependency
Checklist