chore(infra/biome): enable noConstEnum (#7385)

* chore(infra/biome): enable noConstEnum * chore: update rspack-test-tools etc/api.md
web-infra-dev · Jul 31, 2024 · 82674e1 · 82674e1 · rspack-bot · Jul 31, 2024
1 parent c1b1bec
commit 82674e1
Show file tree

Hide file tree

Showing 5 changed files with 4 additions and 5 deletions.
diff --git a/biome.jsonc b/biome.jsonc
@@ -78,7 +78,6 @@
 				"noGlobalAssign": "off",
 				"noGlobalIsNan": "off",
 				"noFallthroughSwitchClause": "off",
-				"noConstEnum": "off",
 				"noConfusingVoidType": "off",
 				"noPrototypeBuiltins": "off",
 				"noImplicitAnyLet": "off",

diff --git a/packages/rspack-test-tools/etc/api.md b/packages/rspack-test-tools/etc/api.md
@@ -324,7 +324,7 @@ export enum ECompilerType {
 }
 
 // @public (undocumented)
-export const enum EDocumentType {
+export enum EDocumentType {
     // (undocumented)
     Fake = "fake",
     // (undocumented)

diff --git a/packages/rspack-test-tools/src/compiler.ts b/packages/rspack-test-tools/src/compiler.ts
@@ -11,7 +11,7 @@ import {
 	type TCompilerStats
 } from "./type";
 
-export const enum ECompilerEvent {
+export enum ECompilerEvent {
 	Build = "build",
 	Option = "option",
 	Create = "create",

diff --git a/packages/rspack-test-tools/src/type.ts b/packages/rspack-test-tools/src/type.ts
@@ -180,7 +180,7 @@ export interface ITestEnv {
 	[key: string]: unknown;
 }
 
-export const enum EDocumentType {
+export enum EDocumentType {
 	Fake = "fake",
 	JSDOM = "jsdom"
 }

diff --git a/packages/rspack/module.d.ts b/packages/rspack/module.d.ts
@@ -109,7 +109,7 @@ declare namespace Rspack {
 		onErrored?: (event: ErroredEvent) => void;
 	}
 
-	const enum HotUpdateStatus {
+	enum HotUpdateStatus {
 		idle = "idle",
 		check = "check",
 		prepare = "prepare",
suite	result
modernjs	❌ failure
_selftest	✅ success
nx	❌ failure
rspress	✅ success
rsbuild	✅ success
examples	✅ success
Name	Base (2024-07-31 9e2cbe9)	Current	Change
10000_development-mode + exec	2.27 s ± 20 ms	2.25 s ± 30 ms	-1.10 %
10000_development-mode_hmr + exec	702 ms ± 11 ms	717 ms ± 5.6 ms	+2.14 %
10000_production-mode + exec	2.76 s ± 39 ms	2.71 s ± 36 ms	-1.92 %
arco-pro_development-mode + exec	1.88 s ± 66 ms	1.88 s ± 69 ms	+0.24 %
arco-pro_development-mode_hmr + exec	433 ms ± 1.7 ms	434 ms ± 2.6 ms	+0.33 %
arco-pro_production-mode + exec	3.45 s ± 114 ms	3.38 s ± 87 ms	-1.90 %
threejs_development-mode_10x + exec	1.75 s ± 25 ms	1.76 s ± 19 ms	+0.73 %
threejs_development-mode_10x_hmr + exec	863 ms ± 8.3 ms	879 ms ± 9.9 ms	+1.95 %
threejs_production-mode_10x + exec	5.49 s ± 26 ms	5.51 s ± 40 ms	+0.34 %