Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(infra/biome): enable noConstEnum #7385

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

shulaoda
Copy link
Collaborator

Summary

Related to #7182

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Jul 31, 2024

Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 3c1da9d
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/66aa22e7ff32370008da90b1

SoonIter
SoonIter previously approved these changes Jul 31, 2024
Copy link
Member

@SoonIter SoonIter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😁 The rule that caused large changes has been opened, and the remaining rules can be opened in batches

@shulaoda
Copy link
Collaborator Author

The rule that caused large changes has been opened, and the remaining rules can be opened in batches

agree

@SoonIter SoonIter force-pushed the chore/biome-remove-noConstEnum branch from 057b29c to 0c2ff70 Compare July 31, 2024 11:11
@SoonIter SoonIter enabled auto-merge (squash) July 31, 2024 11:13
auto-merge was automatically disabled July 31, 2024 11:41

Head branch was pushed to by a user without write access

@SoonIter SoonIter enabled auto-merge (squash) July 31, 2024 11:46
@SoonIter SoonIter merged commit 82674e1 into web-infra-dev:main Jul 31, 2024
28 checks passed
@shulaoda shulaoda deleted the chore/biome-remove-noConstEnum branch July 31, 2024 12:42
@chenjiahan chenjiahan mentioned this pull request Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants