Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove unused vars & prefer const & remove default generic value #4079

Merged
merged 2 commits into from
Oct 21, 2023
Merged

chore: remove unused vars & prefer const & remove default generic value #4079

merged 2 commits into from
Oct 21, 2023

Conversation

SnowingFox
Copy link
Contributor

Summary

  • Remove some unused vars
  • Prefer const which is not reassigned
  • Remove generic which has the same default type value

image

Test Plan

@SnowingFox SnowingFox requested a review from a team August 31, 2023 06:48
@CLAassistant
Copy link

CLAassistant commented Aug 31, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@hyf0
Copy link
Collaborator

hyf0 commented Sep 1, 2023

You might need to squash you commits and exclude the commit of liumengjie.react, so the CLA check could be passed.

@SnowingFox
Copy link
Contributor Author

The ci is really weird

@hardfist
Copy link
Contributor

@SnowingFox are you willing to fix the conflict and we will review it ASAP

@SnowingFox
Copy link
Contributor Author

@SnowingFox are you willing to fix the conflict and we will review it ASAP

done

@hardfist hardfist added this pull request to the merge queue Oct 21, 2023
@hardfist
Copy link
Contributor

@SnowingFox thanks!

Merged via the queue into web-infra-dev:main with commit dbff29d Oct 21, 2023
14 checks passed
IWANABETHATGUY pushed a commit that referenced this pull request Oct 22, 2023
@SnowingFox @IWANABETHATGUY
chore: remove unused vars & prefer const & remove default generic val…
0a9cd0c 
…ue (#4079)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hardfist hardfist hardfist approved these changes

@h-a-n-a h-a-n-a Awaiting requested review from h-a-n-a

@Boshen Boshen Awaiting requested review from Boshen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SnowingFox @CLAassistant @hyf0 @hardfist