-
-
Notifications
You must be signed in to change notification settings - Fork 587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(webpack-test): make tests more future proof #4758
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Boshen
requested review from
jerrykingxyz,
ahabhgk,
IWANABETHATGUY and
ScriptedAlchemy
November 23, 2023 10:32
github-actions
bot
added
the
team
The issue/pr is created by the member of Rspack.
label
Nov 23, 2023
Boshen
commented
Nov 23, 2023
Boshen
commented
Nov 23, 2023
Boshen
force-pushed
the
webpack-test-enhance
branch
from
November 23, 2023 10:38
28e877e
to
c756aa8
Compare
Boshen
commented
Nov 23, 2023
Test Compatibility Diff
Unpassed tests
|
hardfist
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR tries to make webpack-test more future proof by catching more errors where appropriate.
webpack-test
has the assumption where all configs are valid and everything will compile, but this is not the case with Rspack.I also found 2 passing tests so I added to this PR.
Test Plan
Require Documentation?