Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: mini-css-extract-plugin #5072

Merged
merged 1 commit into from
Apr 7, 2024
Merged

feat: mini-css-extract-plugin #5072

merged 1 commit into from
Apr 7, 2024

Conversation

JSerFeng
Copy link
Collaborator

@JSerFeng JSerFeng commented Dec 20, 2023 •
edited
Loading

Summary

close #3210

Test Plan

Require Documentation?

  • No
  • Yes, the corresponding rspack-website PR is __

This was referenced Dec 20, 2023
Merged
Merged
@JSerFeng
Copy link
Collaborator Author

JSerFeng commented Dec 20, 2023 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JSerFeng and the rest of your teammates on Graphite Graphite

@JSerFeng JSerFeng mentioned this pull request Dec 20, 2023
Merged
2 tasks
@github-actions github-actions bot added release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack. labels Dec 20, 2023
@JSerFeng JSerFeng force-pushed the 12-19-feat_mini-css-extract-plugin branch from bde5933 to d711274 Compare December 20, 2023 07:00
@JSerFeng JSerFeng force-pushed the 11-20-feat_compilation_add_pluginImport_and_executeModule branch 2 times, most recently from 84806a3 to 74a76e7 Compare December 20, 2023 07:46
@JSerFeng JSerFeng force-pushed the 12-19-feat_mini-css-extract-plugin branch 6 times, most recently from 6b8031d to 7232ebd Compare December 23, 2023 07:19
@JSerFeng JSerFeng force-pushed the 11-20-feat_compilation_add_pluginImport_and_executeModule branch from 74a76e7 to 2da0c63 Compare December 23, 2023 08:17
@JSerFeng JSerFeng force-pushed the 12-19-feat_mini-css-extract-plugin branch 6 times, most recently from 53f7655 to bfd43c7 Compare December 25, 2023 09:34
@JSerFeng JSerFeng force-pushed the 11-20-feat_compilation_add_pluginImport_and_executeModule branch from 2da0c63 to c3c21f1 Compare December 25, 2023 17:16
@JSerFeng JSerFeng force-pushed the 12-19-feat_mini-css-extract-plugin branch from bfd43c7 to 4986da4 Compare December 25, 2023 17:17
@JSerFeng JSerFeng force-pushed the 11-20-feat_compilation_add_pluginImport_and_executeModule branch from c3c21f1 to 9cedc74 Compare December 26, 2023 18:04
@JSerFeng JSerFeng force-pushed the 12-19-feat_mini-css-extract-plugin branch 4 times, most recently from cf0b8fe to 21d2865 Compare December 29, 2023 06:56
@JSerFeng JSerFeng mentioned this pull request Jan 2, 2024
Merged
2 tasks
@JSerFeng JSerFeng force-pushed the 12-19-feat_mini-css-extract-plugin branch from ea0d21b to 338a581 Compare February 26, 2024 08:42
@JSerFeng
Copy link
Collaborator Author

!canary

@github-actions GitHub Actions
Copy link
Contributor

0.5.4-canary-338a581-20240226090611

@JSerFeng JSerFeng force-pushed the 12-19-feat_mini-css-extract-plugin branch 2 times, most recently from 45dd366 to ab99cf1 Compare April 5, 2024 08:56
@netlify Netlify
Copy link

netlify bot commented Apr 5, 2024 •
edited
Loading

✅ Deploy Preview for rspack ready!

Name Link
🔨 Latest commit 1970628
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/661238f08c8d6500084ca899
😎 Deploy Preview https://deploy-preview-5072--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JSerFeng
Copy link
Collaborator Author

JSerFeng commented Apr 5, 2024

!canary

@JSerFeng JSerFeng force-pushed the 12-19-feat_mini-css-extract-plugin branch 3 times, most recently from 83c6619 to 3ceaf3a Compare April 6, 2024 06:53
@JSerFeng
Copy link
Collaborator Author

JSerFeng commented Apr 6, 2024

!canary

@JSerFeng JSerFeng force-pushed the 12-19-feat_mini-css-extract-plugin branch 3 times, most recently from e5b0d2e to 8a34bc2 Compare April 7, 2024 03:08
@JSerFeng
Copy link
Collaborator Author

JSerFeng commented Apr 7, 2024

!canary

@JSerFeng JSerFeng force-pushed the 12-19-feat_mini-css-extract-plugin branch from 8a34bc2 to 34a4636 Compare April 7, 2024 03:38
ahabhgk
ahabhgk reviewed Apr 7, 2024
View reviewed changes
Copy link
Collaborator

@ahabhgk ahabhgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small naming issue

packages/rspack/src/builtin-plugin/mini-css-extract/index.ts Outdated Show resolved Hide resolved
packages/rspack/src/exports.ts Outdated Show resolved Hide resolved
crates/rspack_binding_options/src/options/raw_builtins/mod.rs Outdated Show resolved Hide resolved
@JSerFeng JSerFeng force-pushed the 12-19-feat_mini-css-extract-plugin branch 2 times, most recently from e943f5e to cdbc55f Compare April 7, 2024 05:37
@JSerFeng
Copy link
Collaborator Author

JSerFeng commented Apr 7, 2024

!canary

@JSerFeng JSerFeng force-pushed the 12-19-feat_mini-css-extract-plugin branch from cdbc55f to 1970628 Compare April 7, 2024 06:10
@JSerFeng JSerFeng merged commit c34411d into main Apr 7, 2024
27 checks passed
@JSerFeng JSerFeng deleted the 12-19-feat_mini-css-extract-plugin branch April 7, 2024 06:25
@hardfist
Copy link
Contributor

hardfist commented Apr 7, 2024

@JSerFeng this need documentation update

@hardfist hardfist added the need documentation Create a tracking issue in rspack-website label Apr 7, 2024
hardfist
hardfist reviewed Apr 7, 2024
View reviewed changes
packages/rspack/src/builtin-plugin/css-extract/index.ts

options: PluginOptions;

constructor(options?: PluginOptions) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this is not working with newTreeshaking:false, we should add warning when newTreeshaking is set to true @JSerFeng

@LingyuCoder LingyuCoder mentioned this pull request Apr 9, 2024
Merged
@JonKusz JonKusz mentioned this pull request Dec 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hardfist hardfist hardfist left review comments

@ahabhgk ahabhgk ahabhgk approved these changes

@h-a-n-a h-a-n-a Awaiting requested review from h-a-n-a

Assignees

@JSerFeng JSerFeng

Labels
need documentation Create a tracking issue in rspack-website release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support mini-css-extract-plugin
3 participants
@JSerFeng @hardfist @ahabhgk