-
-
Notifications
You must be signed in to change notification settings - Fork 620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support error early bail #5084
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
github-actions
bot
added
release: feature
release: feature related release(mr only)
team
The issue/pr is created by the member of Rspack.
labels
Dec 20, 2023
h-a-n-a
force-pushed
the
12-20-feat_support_error_early_bail
branch
from
December 20, 2023 10:57
ac743fe
to
246b536
Compare
h-a-n-a
commented
Dec 21, 2023
h-a-n-a
commented
Dec 21, 2023
h-a-n-a
commented
Dec 21, 2023
Test Compatibility Diff
Unpassed tests
|
h-a-n-a
requested review from
a team,
LingyuCoder,
IWANABETHATGUY and
ScriptedAlchemy
December 21, 2023 12:53
ahabhgk
approved these changes
Dec 21, 2023
IWANABETHATGUY
approved these changes
Dec 21, 2023
2 tasks
ahabhgk
pushed a commit
that referenced
this pull request
Jan 2, 2024
* feat: support error early bail * partial * empty dep * fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
need documentation
Create a tracking issue in rspack-website
release: feature
release: feature related release(mr only)
team
The issue/pr is created by the member of Rspack.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces
option.bail
.With
option.bail
enabled, every module factorization errors will be treated as non-recoverable errors. Webpack usesoption.bail = false
as its default value. closes #5082This PR also refactors current empty dependency implementation:
Up coming PR:
Rspack converts resolve errors directly into recoverable errors, this should be aligned with webpack (i.e using
option.bail
to determine whether it is a recoverable error.)Test Plan
Enabled
webpack-test/cases/parsing/issue-2006/test.filter.js
Enabled more compiler test
Require Documentation?