-
-
Notifications
You must be signed in to change notification settings - Fork 618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(mf1.5): add resolve alias for mf runtime #5239
Conversation
Test Compatibility Diff
Unpassed tests1 ⚪️ ConfigTestCases additional-pass simple simple: TODO |
Additionally, I took a look at the rspack/packages/rspack/package.json Line 84 in c24cd55
It may cause pnpm resolution issues(when |
I added it to dependencies, should I also add it to peer? |
Sorry, I misunderstood your intention. If module-federation dependencies are intended to be provided by '@rspack/core' then it's not necessary. I though it is intended to be provided by users. But I still cannot find this '@module-federation/webpack-bundler-runtime' and '@module-federation/runtime' |
it's in the @module-federation/runtime-tools, and resolved from @module-federation/runtime-tools |
I see. Then, it's good to go ;-) |
Summary
Test Plan
Require Documentation?