perf: improve performance of eval-source-map #7630
Merged
+184
−30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
using simd_json to convert string to json string, the improvement is small, but better than current, especially if the number of modules is super large.
encoding url always allocate new string, but in most cases there is no replacement at all, so using Cow to avoid unnessary allocation here.
here is the improvement I saw with my MacBook Pro M1, using this repo, CASE=9000
Before
After
Checklist