perf: improve performance of eval-source-map

Cargo.toml

@@ -52,6 +52,7 @@ rustc-hash         = { version = "1.1.0" }
 schemars           = { version = "0.8.16" }
 serde              = { version = "1.0.197" }
 serde_json         = { version = "1.0.115" }
+simd-json          = { version = "0.13.10" }
 stacker            = { version = "0.1.15" }
 sugar_path         = { version = "1.2.0", features = ["cached_current_dir"] }
 syn                = { version = "2.0.58" }

crates/rspack_plugin_devtool/Cargo.toml

@@ -17,14 +17,15 @@ pathdiff                 = { workspace = true }
 rayon                    = { workspace = true }
 regex                    = { workspace = true }
 rspack_base64            = { version = "0.1.0", path = "../rspack_base64" }
+rspack_collections       = { version = "0.1.0", path = "../rspack_collections" }
 rspack_core              = { version = "0.1.0", path = "../rspack_core" }
 rspack_error             = { version = "0.1.0", path = "../rspack_error" }
 rspack_hash              = { version = "0.1.0", path = "../rspack_hash" }
 rspack_hook              = { version = "0.1.0", path = "../rspack_hook" }
 rspack_plugin_javascript = { version = "0.1.0", path = "../rspack_plugin_javascript" }
 rspack_util              = { version = "0.1.0", path = "../rspack_util" }
 rustc-hash               = { workspace = true }
-serde_json               = { workspace = true }
+simd-json                = { workspace = true }
 tracing                  = { workspace = true }
 
 [package.metadata.cargo-shear]

crates/rspack_plugin_devtool/src/eval_dev_tool_module_plugin.rs

@@ -1,8 +1,9 @@
-use std::hash::Hash;
 use std::sync::LazyLock;
+use std::{borrow::Cow, hash::Hash};
 
 use dashmap::DashMap;
 use derivative::Derivative;
+use rspack_collections::UkeySet;
 use rspack_core::{
   rspack_sources::{BoxSource, RawSource, Source, SourceExt},
   ApplyContext, BoxModule, ChunkInitFragments, ChunkUkey, Compilation, CompilationParams,
@@ -15,8 +16,6 @@ use rspack_plugin_javascript::{
   JavascriptModulesChunkHash, JavascriptModulesInlineInRuntimeBailout,
   JavascriptModulesRenderModuleContent, JsPlugin, RenderSource,
 };
-use rustc_hash::FxHashSet as HashSet;
-use serde_json::json;
 
 use crate::{
   module_filename_helpers::ModuleFilenameHelpers, ModuleFilenameTemplate, ModuleOrSource,
@@ -138,7 +137,11 @@ fn eval_devtool_plugin_render_module_content(
     );
     // TODO: Implement support for the trustedTypes option.
     // This will depend on the additionalModuleRuntimeRequirements hook.
-    RawSource::from(format!("eval({});", json!(format!("{source}{footer}")))).boxed()
+    RawSource::from(format!(
+      "eval({});",
+      simd_json::to_string(&format!("{source}{footer}")).expect("failed to parse string")
+    ))
+    .boxed()
   };
 
   self.cache.insert(origin_source, source.clone());
@@ -184,36 +187,50 @@ impl Plugin for EvalDevToolModulePlugin {
   }
 }
 
-// https://tc39.es/ecma262/#sec-encodeuri-uri
-fn encode_uri(uri: &str) -> String {
-  encode(uri, ";/?:@&=+$,#")
-}
-
-static ALWAYS_UNESCAPED: LazyLock<HashSet<char>> = LazyLock::new(|| {
-  "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789-._~!*'()"
+// https://tc39.es/ecma262/#sec-encode
+// UNESCAPED is combined by ALWAYS_UNESCAPED and ";/?:@&=+$,#"
+static UNESCAPED: LazyLock<UkeySet<u32>> = LazyLock::new(|| {
+  "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789-._~!*'();/?:@&=+$,#"
     .chars()
+    .map(|c| c as u32)
     .collect()
 });
 
 // https://tc39.es/ecma262/#sec-encode
-fn encode(string: &str, extra_unescaped: &str) -> String {
+fn encode_uri(string: &str) -> Cow<str> {
   // Let R be the empty String.
-  let mut r = String::new();
+  let mut r = Cow::Borrowed(string);
   // Let alwaysUnescaped be the string-concatenation of the ASCII word characters and "-.!~*'()".
-  let always_unescaped = ALWAYS_UNESCAPED.clone();
-  // Let unescapedSet be the string-concatenation of alwaysUnescaped and extraUnescaped.
-  let unescaped_set: HashSet<char> = always_unescaped
-    .union(&extra_unescaped.chars().collect::<HashSet<_>>())
-    .cloned()
-    .collect();
-  for c in string.chars() {
-    if unescaped_set.contains(&c) {
-      r.push(c);
+  for (byte_idx, c) in string.char_indices() {
+    if UNESCAPED.contains(&(c as u32)) {
+      match r {
+        Cow::Borrowed(_) => {
+          continue;
+        }
+        Cow::Owned(mut inner) => {
+          inner.push(c);
+          r = Cow::Owned(inner);
+        }
+      }
     } else {
-      let mut b = [0u8; 4];
-      let octets = c.encode_utf8(&mut b).as_bytes().to_vec();
-      for octet in octets {
-        r.push_str(&format!("%{:02X}", octet));
+      match r {
+        Cow::Borrowed(_) => {
+          let mut s = string[0..byte_idx].to_string();
+          let mut b = [0u8; 4];
+          let octets = c.encode_utf8(&mut b).as_bytes().to_vec();
+          for octet in octets {
+            s.push_str(&format!("%{:02X}", octet));
+          }
+          r = Cow::Owned(s);
+        }
+        Cow::Owned(mut inner) => {
+          let mut b = [0u8; 4];
+          let octets = c.encode_utf8(&mut b).as_bytes().to_vec();
+          for octet in octets {
+            inner.push_str(&format!("%{:02X}", octet));
+          }
+          r = Cow::Owned(inner);
+        }
       }
     }
   }

crates/rspack_plugin_devtool/src/eval_source_map_dev_tool_plugin.rs

@@ -16,7 +16,6 @@ use rspack_plugin_javascript::{
   JavascriptModulesRenderModuleContent, JsPlugin, RenderSource,
 };
 use rspack_util::identifier::make_paths_absolute;
-use serde_json::json;
 
 use crate::{
   module_filename_helpers::ModuleFilenameHelpers, ModuleFilenameTemplate, ModuleOrSource,
@@ -174,7 +173,11 @@ fn eval_source_map_devtool_plugin_render_module_content(
       let base64 = rspack_base64::encode_to_string(&map_buffer);
       let footer =
         format!("\n//# sourceMappingURL=data:application/json;charset=utf-8;base64,{base64}");
-      RawSource::from(format!("eval({});", json!(format!("{source}{footer}")))).boxed()
+      RawSource::from(format!(
+        "eval({});",
+        simd_json::to_string(&format!("{source}{footer}")).expect("should convert to string")
+      ))
+      .boxed()
     };
     self.cache.insert(origin_source, source.clone());
     render_source.source = source;