Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: reduce heap allocations for RuntimeModule #8620

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Conversation

h-a-n-a
Copy link
Contributor

@h-a-n-a h-a-n-a commented Dec 4, 2024

Summary

Low hanging fruits for RuntimeModule.

See: web-infra-dev/rspack-sources#129

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added release: performance release: performance related release(mr only) team The issue/pr is created by the member of Rspack. labels Dec 4, 2024
Copy link

netlify bot commented Dec 4, 2024

Deploy Preview for rspack ready!

Name Link
🔨 Latest commit 7013112
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/675011bdc182ab00081989aa
😎 Deploy Preview https://deploy-preview-8620--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@h-a-n-a h-a-n-a marked this pull request as ready for review December 4, 2024 08:32
@h-a-n-a h-a-n-a enabled auto-merge (squash) December 4, 2024 08:32
@h-a-n-a h-a-n-a requested a review from SyMind December 4, 2024 08:35
@h-a-n-a
Copy link
Contributor Author

h-a-n-a commented Dec 4, 2024

!bench

@rspack-bot
Copy link

rspack-bot commented Dec 4, 2024

📝 Benchmark detail: Open

Name Base (2024-12-04 044e8e3) Current Change
10000_big_production-mode_disable-minimize + exec 42.6 s ± 1.25 s 36.4 s ± 129 ms -14.53 %
10000_development-mode + exec 1.83 s ± 47 ms 1.81 s ± 45 ms -1.44 %
10000_development-mode_hmr + exec 647 ms ± 3.9 ms 647 ms ± 5.9 ms -0.02 %
10000_production-mode + exec 2.41 s ± 41 ms 2.35 s ± 28 ms -2.57 %
arco-pro_development-mode + exec 1.75 s ± 70 ms 1.77 s ± 60 ms +0.93 %
arco-pro_development-mode_hmr + exec 426 ms ± 2 ms 427 ms ± 2.3 ms +0.15 %
arco-pro_production-mode + exec 3.1 s ± 71 ms 3.15 s ± 82 ms +1.63 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.13 s ± 77 ms 3.19 s ± 100 ms +1.74 %
threejs_development-mode_10x + exec 1.63 s ± 20 ms 1.65 s ± 18 ms +1.59 %
threejs_development-mode_10x_hmr + exec 807 ms ± 11 ms 801 ms ± 13 ms -0.71 %
threejs_production-mode_10x + exec 4.91 s ± 26 ms 4.91 s ± 27 ms +0.11 %
10000_big_production-mode_disable-minimize + rss memory 13449 MiB ± 447 MiB 10327 MiB ± 55.5 MiB -23.22 %
10000_development-mode + rss memory 784 MiB ± 25.4 MiB 788 MiB ± 29.9 MiB +0.56 %
10000_development-mode_hmr + rss memory 1896 MiB ± 541 MiB 1902 MiB ± 410 MiB +0.29 %
10000_production-mode + rss memory 663 MiB ± 27.2 MiB 683 MiB ± 40.6 MiB +3.03 %
arco-pro_development-mode + rss memory 731 MiB ± 34.9 MiB 706 MiB ± 41.2 MiB -3.36 %
arco-pro_development-mode_hmr + rss memory 926 MiB ± 68.8 MiB 855 MiB ± 106 MiB -7.65 %
arco-pro_production-mode + rss memory 834 MiB ± 35.9 MiB 809 MiB ± 62.1 MiB -2.98 %
arco-pro_production-mode_generate-package-json-webpack-plugin + rss memory 879 MiB ± 37.5 MiB 824 MiB ± 36.5 MiB -6.17 %
threejs_development-mode_10x + rss memory 823 MiB ± 46.7 MiB 769 MiB ± 36.4 MiB -6.62 %
threejs_development-mode_10x_hmr + rss memory 2147 MiB ± 152 MiB 1765 MiB ± 171 MiB -17.79 %
threejs_production-mode_10x + rss memory 1034 MiB ± 53.5 MiB 1104 MiB ± 84 MiB +6.76 %

@h-a-n-a h-a-n-a merged commit bd25fbf into main Dec 4, 2024
37 checks passed
@h-a-n-a h-a-n-a deleted the low-hangings branch December 4, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: performance release: performance related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants