Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: avoid heap allocation for getting connections #8625

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

ahabhgk
Copy link
Contributor

@ahabhgk ahabhgk commented Dec 4, 2024

Summary

avoid heap allocation for getting connections

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@ahabhgk ahabhgk requested a review from jerrykingxyz as a code owner December 4, 2024 12:36
@ahabhgk ahabhgk requested a review from JSerFeng December 4, 2024 12:36
@github-actions github-actions bot added the release: performance release: performance related release(mr only) label Dec 4, 2024
Copy link

netlify bot commented Dec 4, 2024

Deploy Preview for rspack ready!

Name Link
🔨 Latest commit 1126bf5
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67504cbd03f74b00095e3d90
😎 Deploy Preview https://deploy-preview-8625--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Dec 4, 2024
@ahabhgk
Copy link
Contributor Author

ahabhgk commented Dec 4, 2024

!bench

@rspack-bot
Copy link

rspack-bot commented Dec 4, 2024

📝 Benchmark detail: Open

Name Base (2024-12-04 044e8e3) Current Change
10000_big_production-mode_disable-minimize + exec 42.6 s ± 1.25 s 36.3 s ± 112 ms -14.60 %
10000_development-mode + exec 1.83 s ± 47 ms 1.78 s ± 37 ms -2.94 %
10000_development-mode_hmr + exec 647 ms ± 3.9 ms 638 ms ± 15 ms -1.37 %
10000_production-mode + exec 2.41 s ± 41 ms 2.35 s ± 65 ms -2.64 %
arco-pro_development-mode + exec 1.75 s ± 70 ms 1.73 s ± 89 ms -1.41 %
arco-pro_development-mode_hmr + exec 426 ms ± 2 ms 424 ms ± 1.2 ms -0.48 %
arco-pro_production-mode + exec 3.1 s ± 71 ms 3.15 s ± 57 ms +1.34 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.13 s ± 77 ms 3.21 s ± 130 ms +2.39 %
threejs_development-mode_10x + exec 1.63 s ± 20 ms 1.65 s ± 34 ms +1.12 %
threejs_development-mode_10x_hmr + exec 807 ms ± 11 ms 798 ms ± 11 ms -1.16 %
threejs_production-mode_10x + exec 4.91 s ± 26 ms 4.9 s ± 23 ms -0.04 %
10000_big_production-mode_disable-minimize + rss memory 13449 MiB ± 447 MiB 10316 MiB ± 57.3 MiB -23.29 %
10000_development-mode + rss memory 784 MiB ± 25.4 MiB 774 MiB ± 16.5 MiB -1.25 %
10000_development-mode_hmr + rss memory 1896 MiB ± 541 MiB 1980 MiB ± 489 MiB +4.42 %
10000_production-mode + rss memory 663 MiB ± 27.2 MiB 661 MiB ± 39.4 MiB -0.34 %
arco-pro_development-mode + rss memory 731 MiB ± 34.9 MiB 712 MiB ± 40.2 MiB -2.61 %
arco-pro_development-mode_hmr + rss memory 926 MiB ± 68.8 MiB 885 MiB ± 107 MiB -4.48 %
arco-pro_production-mode + rss memory 834 MiB ± 35.9 MiB 810 MiB ± 35.8 MiB -2.92 %
arco-pro_production-mode_generate-package-json-webpack-plugin + rss memory 879 MiB ± 37.5 MiB 836 MiB ± 46.1 MiB -4.85 %
threejs_development-mode_10x + rss memory 823 MiB ± 46.7 MiB 780 MiB ± 49.3 MiB -5.24 %
threejs_development-mode_10x_hmr + rss memory 2147 MiB ± 152 MiB 1801 MiB ± 237 MiB -16.13 %
threejs_production-mode_10x + rss memory 1034 MiB ± 53.5 MiB 1088 MiB ± 56 MiB +5.27 %

@ahabhgk ahabhgk enabled auto-merge (squash) December 4, 2024 12:39
@ahabhgk ahabhgk merged commit c26a11a into main Dec 4, 2024
37 checks passed
@ahabhgk ahabhgk deleted the perf-avoid-heap-alloc-for-connections branch December 4, 2024 15:00
@JSerFeng
Copy link
Contributor

JSerFeng commented Dec 4, 2024

For real ?
image
I didn't realize clone costs that much

@chenjiahan
Copy link
Member

chenjiahan commented Dec 5, 2024

@JSerFeng I think it's related to #8620 and #8602

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: performance release: performance related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants