-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[math functions] remove incorrect tests #337
Comments
@danielsakhapov can these tests be updated in some way, or is there no pass condition that makes sense? |
@foolip we can test only for the specified value and not the computed one. |
Thanks @danielsakhapov! @jgraham can you handle this proposal for Gecko? |
To make it clear, the proposal would be to only keep the tests for specified value in Interop 2023. Tests for the computed value would be removed or split out. |
@emilio does removing the computed value tests seem reasonable here? Should we be testing some other behaviour instead? |
We should probably test that those produce what the spec says, which IIRC is that cc @CanadaHonk |
I agree that we should change the computed value tests based on the language in the spec here:
|
@emilio Please have a look at my change web-platform-tests/wpt#40567 |
Change tests results to see that NaN goes to 0 on top-level as per: https://drafts.csswg.org/css-values-4/#top-level-calculation And correctly handle the infinity expectations. Remove -infinity for matrix as it can't round-trip. Reviewed: #40567 Discussed: web-platform-tests/interop#337 Change-Id: I4a0a7273c9e82a7f6e21b3bf8ed877b62076e3d3
Change tests results to see that NaN goes to 0 on top-level as per: https://drafts.csswg.org/css-values-4/#top-level-calculation And correctly handle the infinity expectations. Remove -infinity for matrix as it can't round-trip. Reviewed: #40567 Discussed: web-platform-tests/interop#337 Change-Id: I4a0a7273c9e82a7f6e21b3bf8ed877b62076e3d3 Co-authored-by: Daniil Sakhapov <sakhapov@chromium.org>
…handle NaN and infinity, a=testonly Automatic update from web-platform-tests Fix wpt tests for css math functions to handle NaN and infinity (#40567) Change tests results to see that NaN goes to 0 on top-level as per: https://drafts.csswg.org/css-values-4/#top-level-calculation And correctly handle the infinity expectations. Remove -infinity for matrix as it can't round-trip. Reviewed: web-platform-tests/wpt#40567 Discussed: web-platform-tests/interop#337 Change-Id: I4a0a7273c9e82a7f6e21b3bf8ed877b62076e3d3 Co-authored-by: Daniil Sakhapov <sakhapov@chromium.org> -- wpt-commits: 4e1fc86b7e59919575c9832142e8d81217b3ff02 wpt-pr: 40567
…handle NaN and infinity, a=testonly Automatic update from web-platform-tests Fix wpt tests for css math functions to handle NaN and infinity (#40567) Change tests results to see that NaN goes to 0 on top-level as per: https://drafts.csswg.org/css-values-4/#top-level-calculation And correctly handle the infinity expectations. Remove -infinity for matrix as it can't round-trip. Reviewed: web-platform-tests/wpt#40567 Discussed: web-platform-tests/interop#337 Change-Id: I4a0a7273c9e82a7f6e21b3bf8ed877b62076e3d3 Co-authored-by: Daniil Sakhapov <sakhapovchromium.org> -- wpt-commits: 4e1fc86b7e59919575c9832142e8d81217b3ff02 wpt-pr: 40567 UltraBlame original commit: be20ef0ed97bfd3bebfe2cf91cb8965e9cc88ec4
…handle NaN and infinity, a=testonly Automatic update from web-platform-tests Fix wpt tests for css math functions to handle NaN and infinity (#40567) Change tests results to see that NaN goes to 0 on top-level as per: https://drafts.csswg.org/css-values-4/#top-level-calculation And correctly handle the infinity expectations. Remove -infinity for matrix as it can't round-trip. Reviewed: web-platform-tests/wpt#40567 Discussed: web-platform-tests/interop#337 Change-Id: I4a0a7273c9e82a7f6e21b3bf8ed877b62076e3d3 Co-authored-by: Daniil Sakhapov <sakhapovchromium.org> -- wpt-commits: 4e1fc86b7e59919575c9832142e8d81217b3ff02 wpt-pr: 40567 UltraBlame original commit: be20ef0ed97bfd3bebfe2cf91cb8965e9cc88ec4
…handle NaN and infinity, a=testonly Automatic update from web-platform-tests Fix wpt tests for css math functions to handle NaN and infinity (#40567) Change tests results to see that NaN goes to 0 on top-level as per: https://drafts.csswg.org/css-values-4/#top-level-calculation And correctly handle the infinity expectations. Remove -infinity for matrix as it can't round-trip. Reviewed: web-platform-tests/wpt#40567 Discussed: web-platform-tests/interop#337 Change-Id: I4a0a7273c9e82a7f6e21b3bf8ed877b62076e3d3 Co-authored-by: Daniil Sakhapov <sakhapovchromium.org> -- wpt-commits: 4e1fc86b7e59919575c9832142e8d81217b3ff02 wpt-pr: 40567 UltraBlame original commit: be20ef0ed97bfd3bebfe2cf91cb8965e9cc88ec4
…handle NaN and infinity, a=testonly Automatic update from web-platform-tests Fix wpt tests for css math functions to handle NaN and infinity (#40567) Change tests results to see that NaN goes to 0 on top-level as per: https://drafts.csswg.org/css-values-4/#top-level-calculation And correctly handle the infinity expectations. Remove -infinity for matrix as it can't round-trip. Reviewed: web-platform-tests/wpt#40567 Discussed: web-platform-tests/interop#337 Change-Id: I4a0a7273c9e82a7f6e21b3bf8ed877b62076e3d3 Co-authored-by: Daniil Sakhapov <sakhapov@chromium.org> -- wpt-commits: 4e1fc86b7e59919575c9832142e8d81217b3ff02 wpt-pr: 40567
Test List
https://wpt.fyi/results/css/css-values/exp-log-serialize.html and https://wpt.fyi/results/css/css-values/round-mod-rem-serialize.html
Rationale
We can't expect -infinity and NaN as a computed value for opacity and transform, so I propose either to remove them or test only the specified value.
The text was updated successfully, but these errors were encountered: