Fix wpt tests for css math functions to handle NaN and infinity #40567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jun 15, 2023
emilio
approved these changes
Jun 15, 2023
Change tests results to see that NaN goes to 0 on top-level as per: https://drafts.csswg.org/css-values-4/#top-level-calculation And correctly handle the infinity expectations. Remove -infinity for matrix as it can't round-trip. Reviewed: #40567 Discussed: web-platform-tests/interop#337 Change-Id: I4a0a7273c9e82a7f6e21b3bf8ed877b62076e3d3
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4615569
branch
from
6bee41c to
43f7d77
Compare
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jul 12, 2023
…handle NaN and infinity, a=testonly Automatic update from web-platform-tests Fix wpt tests for css math functions to handle NaN and infinity (#40567) Change tests results to see that NaN goes to 0 on top-level as per: https://drafts.csswg.org/css-values-4/#top-level-calculation And correctly handle the infinity expectations. Remove -infinity for matrix as it can't round-trip. Reviewed: web-platform-tests/wpt#40567 Discussed: web-platform-tests/interop#337 Change-Id: I4a0a7273c9e82a7f6e21b3bf8ed877b62076e3d3 Co-authored-by: Daniil Sakhapov <sakhapov@chromium.org> -- wpt-commits: 4e1fc86b7e59919575c9832142e8d81217b3ff02 wpt-pr: 40567
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Jul 16, 2023
…handle NaN and infinity, a=testonly Automatic update from web-platform-tests Fix wpt tests for css math functions to handle NaN and infinity (#40567) Change tests results to see that NaN goes to 0 on top-level as per: https://drafts.csswg.org/css-values-4/#top-level-calculation And correctly handle the infinity expectations. Remove -infinity for matrix as it can't round-trip. Reviewed: web-platform-tests/wpt#40567 Discussed: web-platform-tests/interop#337 Change-Id: I4a0a7273c9e82a7f6e21b3bf8ed877b62076e3d3 Co-authored-by: Daniil Sakhapov <sakhapovchromium.org> -- wpt-commits: 4e1fc86b7e59919575c9832142e8d81217b3ff02 wpt-pr: 40567 UltraBlame original commit: be20ef0ed97bfd3bebfe2cf91cb8965e9cc88ec4
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Jul 16, 2023
…handle NaN and infinity, a=testonly Automatic update from web-platform-tests Fix wpt tests for css math functions to handle NaN and infinity (#40567) Change tests results to see that NaN goes to 0 on top-level as per: https://drafts.csswg.org/css-values-4/#top-level-calculation And correctly handle the infinity expectations. Remove -infinity for matrix as it can't round-trip. Reviewed: web-platform-tests/wpt#40567 Discussed: web-platform-tests/interop#337 Change-Id: I4a0a7273c9e82a7f6e21b3bf8ed877b62076e3d3 Co-authored-by: Daniil Sakhapov <sakhapovchromium.org> -- wpt-commits: 4e1fc86b7e59919575c9832142e8d81217b3ff02 wpt-pr: 40567 UltraBlame original commit: be20ef0ed97bfd3bebfe2cf91cb8965e9cc88ec4
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Jul 16, 2023
…handle NaN and infinity, a=testonly Automatic update from web-platform-tests Fix wpt tests for css math functions to handle NaN and infinity (#40567) Change tests results to see that NaN goes to 0 on top-level as per: https://drafts.csswg.org/css-values-4/#top-level-calculation And correctly handle the infinity expectations. Remove -infinity for matrix as it can't round-trip. Reviewed: web-platform-tests/wpt#40567 Discussed: web-platform-tests/interop#337 Change-Id: I4a0a7273c9e82a7f6e21b3bf8ed877b62076e3d3 Co-authored-by: Daniil Sakhapov <sakhapovchromium.org> -- wpt-commits: 4e1fc86b7e59919575c9832142e8d81217b3ff02 wpt-pr: 40567 UltraBlame original commit: be20ef0ed97bfd3bebfe2cf91cb8965e9cc88ec4
ErichDonGubler
pushed a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Jul 16, 2023
…handle NaN and infinity, a=testonly Automatic update from web-platform-tests Fix wpt tests for css math functions to handle NaN and infinity (#40567) Change tests results to see that NaN goes to 0 on top-level as per: https://drafts.csswg.org/css-values-4/#top-level-calculation And correctly handle the infinity expectations. Remove -infinity for matrix as it can't round-trip. Reviewed: web-platform-tests/wpt#40567 Discussed: web-platform-tests/interop#337 Change-Id: I4a0a7273c9e82a7f6e21b3bf8ed877b62076e3d3 Co-authored-by: Daniil Sakhapov <sakhapov@chromium.org> -- wpt-commits: 4e1fc86b7e59919575c9832142e8d81217b3ff02 wpt-pr: 40567
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change tests results to see that NaN goes to 0 on top-level as per:
https://drafts.csswg.org/css-values-4/#top-level-calculation
And correctly handle the infinity expectations. Remove -infinity for
matrix as it can't round-trip.
Reviewed: #40567
Discussed: web-platform-tests/interop#337
Change-Id: I4a0a7273c9e82a7f6e21b3bf8ed877b62076e3d3
Reviewed-on: https://chromium-review.googlesource.com/4615569
WPT-Export-Revision: 0b8bb4fdbd19fdf98480306b1dfe79643fee4d40