-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The transition-behavior
CSS property
#580
Comments
Original proposal: #495 |
It looks like this test^ is testing whether the property parses as-expected. For this to be in interop-2024, we would probably also want tests for the functional behavior (i.e. computed values of properties that are being transitioned when this is in effect) -- do you know if we have any of those sorts of test in WPT yet? |
There are a bunch of tests which are technically testing it: https://github.com/search?q=repo%3Aweb-platform-tests%2Fwpt%20allow-discrete&type=code
I'll add some more tests for existing properties. I originally had one giant test for all discrete properties but it was too big and would have timeouts. |
This WPT PR should add transition-behavior testing to many existing WPTs: web-platform-tests/wpt#42857 |
@josepharhar with web-platform-tests/wpt#42857 landed, can you link to all of the tests that are in scope for this proposal? |
Unfortunately some of those WPTs are part of interop-2023, so this change seems to have accidentally moved-the-goalposts for interop2023 to now require Could we backout or fix things one way or another so as not to have an impact on interop-2023 targets? |
(ah Joey already replied over there - thanks Joey!) |
If we can't change existing tests then I'm not sure what the best way is to test transition-behavior on all existing CSS properties, but maybe we can do that after interop2023 is over...? In any case, the tests I mentioned in my previous comment are still good tests for transition-behavior. |
Yeah, this is sort of a sticky situation -- I think we definitely want to reland those tests after Interop2023 is "over" (in the sense that we can add to the tests that are part of Interop2023). (And we don't want to forget to do that!) I think the best way to test that So we're stuck in a situation where, while we do have a bunch of tests, probably the bulk of the coverage of testing across all CSS properties can't land until Interop2023 is "done" (in the sense that we're free to add stuff to tests that are part of Interop2023). I don't think we should try to land a "workaround" for this problem because I'm having trouble imagining a workaround that doesn't impose ongoing maintenance costs as we add future CSS properties. |
Yeah -- for the purpose of assessing this interop-2024 proposal, I think we can consider the answer to "does this have WPT tests" to be: yes, they're in this PR which for technical/interop-2023 reasons can't be merged into upstream wpt until interop-2023 is "done" as dbaron noted (which I imagine is... mid-to-late-January, I guess?) In the unlikely case that any implementer (outside of Chromium folks who've already implemented this property) happen to get to this before then, they can apply that PR locally so they can test their implementation, if they like. |
This proposal has been accepted as part of Interop 2024! On behalf of the entire Interop team, thank you for proposing it. You’ll be able to track progress on this topic throughout the year via the Interop 2024 dashboard. |
Original patch: https://chromium-review.googlesource.com/c/chromium/src/+/4989757 Revert: https://chromium-review.googlesource.com/c/chromium/src/+/5038074 Now that interop2023 has been frozen and interop2024 has started with support for allow-discrete, we can reapply these WPT changes. web-platform-tests/interop#580 web-platform-tests/wpt.fyi#3639 Change-Id: Ic5397d2be86e540e82a6f73746d8450f9832e790
Original patch: https://chromium-review.googlesource.com/c/chromium/src/+/4989757 Revert: https://chromium-review.googlesource.com/c/chromium/src/+/5038074 Now that interop2023 has been frozen and interop2024 has started with support for allow-discrete, we can reapply these WPT changes. web-platform-tests/interop#580 web-platform-tests/wpt.fyi#3639 Change-Id: Ic5397d2be86e540e82a6f73746d8450f9832e790
Original patch: https://chromium-review.googlesource.com/c/chromium/src/+/4989757 Revert: https://chromium-review.googlesource.com/c/chromium/src/+/5038074 Now that interop2023 has been frozen and interop2024 has started with support for allow-discrete, we can reapply these WPT changes. web-platform-tests/interop#580 web-platform-tests/wpt.fyi#3639 Change-Id: Ic5397d2be86e540e82a6f73746d8450f9832e790
This patch changes the test runner for animation tests in WPT to additionally test transition-behavior:allow-discrete for any property that we are running a non-interpolable or non-animatable test on. Original patch: https://chromium-review.googlesource.com/c/chromium/src/+/4989757 Revert: https://chromium-review.googlesource.com/c/chromium/src/+/5038074 Now that interop2023 has been frozen and interop2024 has started with support for allow-discrete, we can reapply these WPT changes. web-platform-tests/interop#580 web-platform-tests/wpt.fyi#3639 Change-Id: Ic5397d2be86e540e82a6f73746d8450f9832e790
This patch changes the test runner for animation tests in WPT to additionally test transition-behavior:allow-discrete for any property that we are running a non-interpolable or non-animatable test on. Original patch: https://chromium-review.googlesource.com/c/chromium/src/+/4989757 Revert: https://chromium-review.googlesource.com/c/chromium/src/+/5038074 Now that interop2023 has been frozen and interop2024 has started with support for allow-discrete, we can reapply these WPT changes. web-platform-tests/interop#580 web-platform-tests/wpt.fyi#3639 Change-Id: Ic5397d2be86e540e82a6f73746d8450f9832e790
This patch changes the test runner for animation tests in WPT to additionally test transition-behavior:allow-discrete for any property that we are running a non-interpolable or non-animatable test on. Original patch: https://chromium-review.googlesource.com/c/chromium/src/+/4989757 Revert: https://chromium-review.googlesource.com/c/chromium/src/+/5038074 Now that interop2023 has been frozen and interop2024 has started with support for allow-discrete, we can reapply these WPT changes. web-platform-tests/interop#580 web-platform-tests/wpt.fyi#3639 Change-Id: Ic5397d2be86e540e82a6f73746d8450f9832e790 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5314252 Commit-Queue: David Baron <dbaron@chromium.org> Reviewed-by: David Baron <dbaron@chromium.org> Auto-Submit: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1264380}
This patch changes the test runner for animation tests in WPT to additionally test transition-behavior:allow-discrete for any property that we are running a non-interpolable or non-animatable test on. Original patch: https://chromium-review.googlesource.com/c/chromium/src/+/4989757 Revert: https://chromium-review.googlesource.com/c/chromium/src/+/5038074 Now that interop2023 has been frozen and interop2024 has started with support for allow-discrete, we can reapply these WPT changes. web-platform-tests/interop#580 web-platform-tests/wpt.fyi#3639 Change-Id: Ic5397d2be86e540e82a6f73746d8450f9832e790 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5314252 Commit-Queue: David Baron <dbaron@chromium.org> Reviewed-by: David Baron <dbaron@chromium.org> Auto-Submit: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1264380}
This patch changes the test runner for animation tests in WPT to additionally test transition-behavior:allow-discrete for any property that we are running a non-interpolable or non-animatable test on. Original patch: https://chromium-review.googlesource.com/c/chromium/src/+/4989757 Revert: https://chromium-review.googlesource.com/c/chromium/src/+/5038074 Now that interop2023 has been frozen and interop2024 has started with support for allow-discrete, we can reapply these WPT changes. web-platform-tests/interop#580 web-platform-tests/wpt.fyi#3639 Change-Id: Ic5397d2be86e540e82a6f73746d8450f9832e790 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5314252 Commit-Queue: David Baron <dbaron@chromium.org> Reviewed-by: David Baron <dbaron@chromium.org> Auto-Submit: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1264380}
This patch changes the test runner for animation tests in WPT to additionally test transition-behavior:allow-discrete for any property that we are running a non-interpolable or non-animatable test on. Original patch: https://chromium-review.googlesource.com/c/chromium/src/+/4989757 Revert: https://chromium-review.googlesource.com/c/chromium/src/+/5038074 Now that interop2023 has been frozen and interop2024 has started with support for allow-discrete, we can reapply these WPT changes. web-platform-tests/interop#580 web-platform-tests/wpt.fyi#3639 Change-Id: Ic5397d2be86e540e82a6f73746d8450f9832e790 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5314252 Commit-Queue: David Baron <dbaron@chromium.org> Reviewed-by: David Baron <dbaron@chromium.org> Auto-Submit: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1264380}
…polable WPTs", a=testonly Automatic update from web-platform-tests Reapply "Add allow-discrete to non-interpolable WPTs" This patch changes the test runner for animation tests in WPT to additionally test transition-behavior:allow-discrete for any property that we are running a non-interpolable or non-animatable test on. Original patch: https://chromium-review.googlesource.com/c/chromium/src/+/4989757 Revert: https://chromium-review.googlesource.com/c/chromium/src/+/5038074 Now that interop2023 has been frozen and interop2024 has started with support for allow-discrete, we can reapply these WPT changes. web-platform-tests/interop#580 web-platform-tests/wpt.fyi#3639 Change-Id: Ic5397d2be86e540e82a6f73746d8450f9832e790 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5314252 Commit-Queue: David Baron <dbaron@chromium.org> Reviewed-by: David Baron <dbaron@chromium.org> Auto-Submit: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1264380} -- wpt-commits: b4d3a4ecdd4dbbc8ed1fe3993ba1f510075c6247 wpt-pr: 44713
…polable WPTs", a=testonly Automatic update from web-platform-tests Reapply "Add allow-discrete to non-interpolable WPTs" This patch changes the test runner for animation tests in WPT to additionally test transition-behavior:allow-discrete for any property that we are running a non-interpolable or non-animatable test on. Original patch: https://chromium-review.googlesource.com/c/chromium/src/+/4989757 Revert: https://chromium-review.googlesource.com/c/chromium/src/+/5038074 Now that interop2023 has been frozen and interop2024 has started with support for allow-discrete, we can reapply these WPT changes. web-platform-tests/interop#580 web-platform-tests/wpt.fyi#3639 Change-Id: Ic5397d2be86e540e82a6f73746d8450f9832e790 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5314252 Commit-Queue: David Baron <dbaron@chromium.org> Reviewed-by: David Baron <dbaron@chromium.org> Auto-Submit: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1264380} -- wpt-commits: b4d3a4ecdd4dbbc8ed1fe3993ba1f510075c6247 wpt-pr: 44713
Description
The
transition-behavior
CSS property allows transitions be specified for discrete properties, likedisplay
.transition-behavior
is needed in order to animate the entry and exit animations of top layer elements, like<dialog>
andpopover
s: https://github.com/chrishtr/rendering/blob/master/entry-exit-animations.mdSpecification
https://drafts.csswg.org/css-transitions-2/#transition-behavior-property
Open Issues
No response
Tests
https://wpt.fyi/results/css/css-transitions/parsing/transition-behavior.html
Current Implementations
Standards Positions
Gecko: mozilla/standards-positions#763
WebKit: WebKit/standards-positions#148
Browser bug reports
No bugs filed yet that I know of
Developer discussions
No response
Polls & Surveys
No response
Existing Usage
https://chromestatus.com/metrics/css/timeline/popularity/766
Workarounds
No response
Accessibility Impact
No response
Privacy Impact
No response
Other
No response
The text was updated successfully, but these errors were encountered: