Reapply "Add allow-discrete to non-interpolable WPTs" #44713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5314252
branch
4 times, most recently
from
c1ed0ff
to
7e5308b
Compare
This patch changes the test runner for animation tests in WPT to additionally test transition-behavior:allow-discrete for any property that we are running a non-interpolable or non-animatable test on. Original patch: https://chromium-review.googlesource.com/c/chromium/src/+/4989757 Revert: https://chromium-review.googlesource.com/c/chromium/src/+/5038074 Now that interop2023 has been frozen and interop2024 has started with support for allow-discrete, we can reapply these WPT changes. web-platform-tests/interop#580 web-platform-tests/wpt.fyi#3639 Change-Id: Ic5397d2be86e540e82a6f73746d8450f9832e790 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5314252 Commit-Queue: David Baron <dbaron@chromium.org> Reviewed-by: David Baron <dbaron@chromium.org> Auto-Submit: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1264380}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5314252
branch
from
7e5308b
to
b7f0ce4
Compare
wpt-pr-bot
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch changes the test runner for animation tests in WPT to
additionally test transition-behavior:allow-discrete for any property
that we are running a non-interpolable or non-animatable test on.
Original patch: https://chromium-review.googlesource.com/c/chromium/src/+/4989757
Revert: https://chromium-review.googlesource.com/c/chromium/src/+/5038074
Now that interop2023 has been frozen and interop2024 has started with
support for allow-discrete, we can reapply these WPT changes.
web-platform-tests/interop#580
web-platform-tests/wpt.fyi#3639
Change-Id: Ic5397d2be86e540e82a6f73746d8450f9832e790
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5314252
Commit-Queue: David Baron <dbaron@chromium.org>
Reviewed-by: David Baron <dbaron@chromium.org>
Auto-Submit: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1264380}