Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infrastructure/ tests don't work with Safari Technology Preview 68 #13800

Closed
foolip opened this issue Oct 30, 2018 · 7 comments · Fixed by #14202
Closed

infrastructure/ tests don't work with Safari Technology Preview 68 #13800

foolip opened this issue Oct 30, 2018 · 7 comments · Fixed by #14202

Comments

@foolip
Copy link
Member

foolip commented Oct 30, 2018

In #13769, STP is being pinned to 67, because STP 68 doesn't seem to work. The configuration was developed in foolip#7, and https://dev.azure.com/foolip/wpt/_build/results?buildId=112&view=logs is a build from when STP 68 was used. The logs contain this over and over:

 0:45.55 DEBUG new state: initializing_browser
 0:45.55 DEBUG Dispatch init
 0:45.56 DEBUG Init called, starting browser and runner
 0:45.56 DEBUG Starting browser with settings {}
 0:45.56 DEBUG Starting WebDriver: /Applications/Safari Technology Preview.app/Contents/MacOS/safaridriver --port=4444
 0:45.56 DEBUG Waiting for WebDriver to become accessible: http://127.0.0.1:4444/
 1:00.95 ERROR WebDriver was not accessible within the timeout:
Traceback (most recent call last):
  File "/Users/vsts/agent/2.141.1/work/1/s/tools/wptrunner/wptrunner/webdriver_server.py", line 73, in _run
    wait_for_service((self.host, self.port))
  File "/Users/vsts/agent/2.141.1/work/1/s/tools/wptrunner/wptrunner/webdriver_server.py", line 265, in wait_for_service
    raise socket.error("Service is unavailable: %s:%i" % addr)
error: Service is unavailable: 127.0.0.1:4444

@burg, are you aware of any trouble with SafariDriver with STP 68?

@foolip foolip self-assigned this Oct 30, 2018
foolip added a commit that referenced this issue Oct 30, 2018
@burg
Copy link
Contributor

burg commented Oct 30, 2018

I am not aware of any issues. Is there anything interesting in the Console.app log related to WebDriver? Are you able to launch safaridriver manually from this release?

@foolip
Copy link
Member Author

foolip commented Oct 30, 2018

@burg is there a way to enable logging for SafariDriver? I can run /Applications/Safari\ Technology\ Preview.app/Contents/MacOS/safaridriver -p 4444 locally and curl http://localhost:4444/status suggests that it works, but it's not behaving the same in CI. One thing that could explain it is if the --enable bit has changed, since I've already run that locally long ago, but it's done every time in CI.

Although, in https://dev.azure.com/foolip/safari-ci-starter-kit/_build/results?buildId=103&view=logs I got STP 68 working with a much simpler setup, so it's not that it's entirely broken. I'm not sure it's deterministic, because I feel like I've seen it fail sometimes and sometimes not. Any debugging tips appreciated.

@burg
Copy link
Contributor

burg commented Nov 1, 2018

You can set defaults write com.apple.WebDriver ProtocolTracingEnabled -bool YES to get protocol spew sent to a log file and to Console.app. However, anything interesting is probably already being logged to Console (i.e., sandbox problem, sudden termination, crashing).

@foolip
Copy link
Member Author

foolip commented Nov 1, 2018

@burg what log file will it get written to?

@burg
Copy link
Contributor

burg commented Nov 1, 2018

"""
Opt-in to generating diagnostic logs by running the following in Terminal.app:

defaults write com.apple.WebDriver ProtocolTracingEnabled 1

After setting this, safaridriver will create diagnostic logs in ~/Library/Logs/com.apple.WebDriver/. These logs contain all the HTTP traffic between safaridriver and your test so that we can see the exact WebDriver commands that failed. If you have existing logs in that directory, remove them first so that extraneous logging is not included.
"""

@foolip
Copy link
Member Author

foolip commented Nov 22, 2018

Looks like the problem is resolved with STP 70: #14198

Thanks @burg for the debugging tips, although I didn't end up debugging. Sometimes waiting works too :/

foolip added a commit that referenced this issue Nov 22, 2018
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Dec 11, 2018
…ology Preview version, a=testonly

Automatic update from web-platform-tests
[Azure Pipelines] Don't pin Safari Technology Preview version (#14202)

Fixes web-platform-tests/wpt#13800.
--

wpt-commits: 4b6b5524b1203233d78d025312b6e918809286f3
wpt-pr: 14202
xeonchen pushed a commit to xeonchen/gecko that referenced this issue Dec 11, 2018
…ology Preview version, a=testonly

Automatic update from web-platform-tests
[Azure Pipelines] Don't pin Safari Technology Preview version (#14202)

Fixes web-platform-tests/wpt#13800.
--

wpt-commits: 4b6b5524b1203233d78d025312b6e918809286f3
wpt-pr: 14202
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Dec 11, 2018
…ology Preview version, a=testonly

Automatic update from web-platform-tests
[Azure Pipelines] Don't pin Safari Technology Preview version (#14202)

Fixes web-platform-tests/wpt#13800.
--

wpt-commits: 4b6b5524b1203233d78d025312b6e918809286f3
wpt-pr: 14202
mykmelez pushed a commit to mykmelez/gecko that referenced this issue Dec 12, 2018
…ology Preview version, a=testonly

Automatic update from web-platform-tests
[Azure Pipelines] Don't pin Safari Technology Preview version (#14202)

Fixes web-platform-tests/wpt#13800.
--

wpt-commits: 4b6b5524b1203233d78d025312b6e918809286f3
wpt-pr: 14202
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Oct 3, 2019
…ology Preview version, a=testonly

Automatic update from web-platform-tests
[Azure Pipelines] Don't pin Safari Technology Preview version (#14202)

Fixes web-platform-tests/wpt#13800.
--

wpt-commits: 4b6b5524b1203233d78d025312b6e918809286f3
wpt-pr: 14202

UltraBlame original commit: 155ddc13d7a0a1da4dc9547d4a4c1f5f2dbf0120
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Oct 3, 2019
…ology Preview version, a=testonly

Automatic update from web-platform-tests
[Azure Pipelines] Don't pin Safari Technology Preview version (#14202)

Fixes web-platform-tests/wpt#13800.
--

wpt-commits: 4b6b5524b1203233d78d025312b6e918809286f3
wpt-pr: 14202

UltraBlame original commit: bcb9f53e5d7b5b3ff11a2512c9bef10b468c4f21
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Oct 3, 2019
…ology Preview version, a=testonly

Automatic update from web-platform-tests
[Azure Pipelines] Don't pin Safari Technology Preview version (#14202)

Fixes web-platform-tests/wpt#13800.
--

wpt-commits: 4b6b5524b1203233d78d025312b6e918809286f3
wpt-pr: 14202

UltraBlame original commit: 155ddc13d7a0a1da4dc9547d4a4c1f5f2dbf0120
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Oct 3, 2019
…ology Preview version, a=testonly

Automatic update from web-platform-tests
[Azure Pipelines] Don't pin Safari Technology Preview version (#14202)

Fixes web-platform-tests/wpt#13800.
--

wpt-commits: 4b6b5524b1203233d78d025312b6e918809286f3
wpt-pr: 14202

UltraBlame original commit: bcb9f53e5d7b5b3ff11a2512c9bef10b468c4f21
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Oct 3, 2019
…ology Preview version, a=testonly

Automatic update from web-platform-tests
[Azure Pipelines] Don't pin Safari Technology Preview version (#14202)

Fixes web-platform-tests/wpt#13800.
--

wpt-commits: 4b6b5524b1203233d78d025312b6e918809286f3
wpt-pr: 14202

UltraBlame original commit: 155ddc13d7a0a1da4dc9547d4a4c1f5f2dbf0120
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Oct 3, 2019
…ology Preview version, a=testonly

Automatic update from web-platform-tests
[Azure Pipelines] Don't pin Safari Technology Preview version (#14202)

Fixes web-platform-tests/wpt#13800.
--

wpt-commits: 4b6b5524b1203233d78d025312b6e918809286f3
wpt-pr: 14202

UltraBlame original commit: bcb9f53e5d7b5b3ff11a2512c9bef10b468c4f21
@See887777

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants