[Azure Pipelines] Don't pin Safari Technology Preview version #14202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, https://dev.azure.com/web-platform-tests/wpt/_build/results?buildId=1083&view=logs for #14198 passed but https://dev.azure.com/web-platform-tests/wpt/_build/results?buildId=1090&view=logs did not. /infrastructure/assumptions/allowed-to-play.html failed. Needs investigation... |
|
It passes (or matches expectations rather) for me locally with macOS 10.13 and STP 70, which are the same versions. |
sideshowbarker
approved these changes
Nov 23, 2018
sideshowbarker
approved these changes
Nov 23, 2018
This reverts commit df94a36.
|
OK, problem didn't repo when reverting to STP 67, and also not when unpinning again. So /infrastructure/assumptions/allowed-to-play.html is probably flaky on Safari. It might have already been flaky however. Since Azure Pipelines is still not blocking, I'll merge this and will see if this keeps happening. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
STP 70 works: #14198
Fixes #13800.