Stop posting PR results to pulls.web-platform-tests.org #11060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jugglinmike
force-pushed
the
dont-update-pulls-dashboard
branch
from
5ccc22f
to
ed0ed4d
Compare
This reverts commit ed0ed4d.
jugglinmike
approved these changes
May 18, 2018
| @@ -248,7 +200,6 @@ def main(): | |||
|
|
|||
| venv = Virtualenv(os.environ.get("VIRTUAL_ENV", os.path.join(wpt_root, "_venv"))) | |||
| venv.install_requirements(os.path.join(wpt_root, "tools", "wptrunner", "requirements.txt")) | |||
| venv.install("requests") | |||
There was a problem hiding this comment.
I've kind of wanted to do this for a while :)
| @@ -281,8 +231,6 @@ def run(venv, wpt_args, **kwargs): | |||
|
|
|||
| setup_logging() | |||
|
|
|||
| browser_name = wpt_args.product.split(":")[0] | |||
There was a problem hiding this comment.
Surprised that the linter doesn't recognized unused variables
There was a problem hiding this comment.
We've had that turned off all the way back to 624c87e. The initial whitelist was essentially just everything we failed at that point.
There was a problem hiding this comment.
Thanks for the context! What do you think about enabling that feature? #11097
|
Thanks for checking that it actually still works @jugglinmike, an important consideration indeed :) |
|
Debugging through TravisCI is the most exciting part of my job! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #10923.
This change is