-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for SVGElement.ownerSVGElement. #1879
base: master
Are you sure you want to change the base?
Conversation
Critic review: https://critic.hoppipolla.co.uk/r/5202 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
Reviewed on critic |
critic looks to be gone? Are the comments archived anywhere else? If not, could you summarise here please? |
|
@nikosandronikos is the OK to be merged? |
Oh actually I see now this seems to be waiting on @heycam to make changes in response to review comments |
@heycam, do you plan to update this? (/me is triaging very old PRs) |
see #49608 |
Please let me know if this is the best way to handle scripted SVG tests. It seemed easier to do everything from an HTML document.