Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for SVGElement.ownerSVGElement #49608

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

karlcow
Copy link
Contributor

@karlcow karlcow commented Dec 10, 2024

Attempt to fix the comments on #1879

@karlcow
Copy link
Contributor Author

karlcow commented Dec 10, 2024

@heycam this was an attempt on fixing on old test.

@sideshowbarker sideshowbarker enabled auto-merge (rebase) December 10, 2024 02:50
@sideshowbarker sideshowbarker enabled auto-merge (squash) December 10, 2024 02:50
@Ms2ger
Copy link
Contributor

Ms2ger commented Dec 10, 2024

I think you're gonna need to rebase

@svgeesus svgeesus removed their request for review December 10, 2024 16:11
@sideshowbarker sideshowbarker force-pushed the karlcow-heycam-svg-comments branch from 346472b to c3161a5 Compare December 11, 2024 03:30
@sideshowbarker sideshowbarker enabled auto-merge (squash) December 11, 2024 03:31
@sideshowbarker sideshowbarker merged commit 8372201 into master Dec 11, 2024
17 checks passed
@sideshowbarker sideshowbarker deleted the karlcow-heycam-svg-comments branch December 11, 2024 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants