AddTestCheckingLangAttributeAffectsLigatures #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The update modifies "transaction lifetime" related WPTs to run not only in window environments but also on dedicated, service, and shared workers. Bug: 41455766 Change-Id: Id6ddf7393057602cb124500af982dcdd33245f55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5907304 Commit-Queue: Rahul Singh <rahsin@microsoft.com> Reviewed-by: Steve Becker <stevebe@microsoft.com> Auto-Submit: Garima Chadha <garimachadha@microsoft.com> Reviewed-by: Rahul Singh <rahsin@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1404583}
The update modifies nested-cloning related WPTs to run not only in window environments but also on dedicated, service, and shared workers. Bug: 41455766 Change-Id: Id93f7d9e4dd06994a6d6c1ba1525976d373fc776 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5912593 Reviewed-by: Steve Becker <stevebe@microsoft.com> Auto-Submit: Garima Chadha <garimachadha@microsoft.com> Reviewed-by: Rahul Singh <rahsin@microsoft.com> Commit-Queue: Rahul Singh <rahsin@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1404581}
The CL adds mojo binding for the language detection in workers. This will fix the test failures in the corresponding WPT tests. The CL also updates the WPT test to run in all types of workers. Bug: 368206184, 388961572 Change-Id: I45f0632bd7df1ed403f88b398494019ea7a35679 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6148112 Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by: Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Jiacheng Guo <gjc@google.com> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/main@{#1404644}
A multicol container fragment typically contains column fragment (fragmentainer) children, but may also contain column spanners, list item markers, and even out-of-flow positioned fragments (if the containing block is the multicol container itself). Remove DCHECK for IsColumnSpanAll(). The test included would fail this DCHECK, but otherwise render correctly. List item markers cannot be anchors. Change-Id: I6640f002b0d37bdf1dbed932f3761bd11e0c7dd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6162757 Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/main@{#1404648}
…atform-tests#50017) * Add test for calling worker constructor from a shared worker. See https://html.spec.whatwg.org/multipage/workers.html#dedicated-workers-and-the-worker-interface - Calling the Worker constructor from Window is covered by worker-constructor.html - Calling the Worker constructor from a DedicatedWorker is covered by WorkerGlobalScope-worker-constructor.html - This patch extends the previous test to also cover the case when the Worker constructor is called from a SharedWorker. w3c/trusted-types#567 * actually perform check for the sink value...
…rver.observe() method. It's allowed, but the buffered option is ignored. This is what Blink does [1], what WebKit does [2]. (Both code blocks are inside the else branch of if `has entryTypes`) The web-platform-test in this change was originally copied from buffered-flag-after-timeout.any.js and modified. [1] https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/timing/performance_observer.cc;l=264-273;drc=78780a188fe3c79fe815b170f4ea33e62ceb6e04 [2] https://searchfox.org/wubkat/rev/6c800745251d53d6486443d63b35828504446c5d/Source/WebCore/page/PerformanceObserver.cpp#90-100 [3] https://searchfox.org/mozilla-central/rev/e24277e20c492b4a785b4488af02cca062ec7c2c/testing/web-platform/tests/performance-timeline/buffered-flag-after-timeout.any.js Differential Revision: https://phabricator.services.mozilla.com/D233447 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1915589 gecko-commit: fb9d78b726556ac65a13e937410fe92f159b203f gecko-reviewers: sefeng
…xceeds the maximum. Currently, only a maximum of two levels of nested "balancing" multicol are allowed. In the third or deeper levels of a multicol container that uses the balancing behavior (`column-fill: balancing`), we don't honor the balancing request and make it act as if `column-count: 1` is set, for performance reasons [1]. In such scenarios, this patch sets the `mForceAuto` to `true`, allowing the content to be laid out regardless of whether the multicol is at the top of the page or not [2]. This prevents the indefinite creation of columns. This change should have minimal impact on real sites, as nested multicol layouts beyond two levels are rare. WARNING: Opening the testcase in Firefox without this patch applied can hang the browser. [1] https://searchfox.org/mozilla-central/rev/ead020d3989d3e9477b353d3d117f9c0f4b16f53/layout/generic/nsColumnSetFrame.cpp#296-301 [2] https://searchfox.org/mozilla-central/rev/6b61714b224f8cdca1a48ef1c51edab027f2c09f/layout/generic/nsColumnSetFrame.cpp#650-654 Differential Revision: https://phabricator.services.mozilla.com/D233711 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1927270 gecko-commit: c0d9ef2b735c417769b9caadbb74056846c38e51 gecko-reviewers: dshin
An assert on the fetchError event is also added to make sure we used the expected URL. Differential Revision: https://phabricator.services.mozilla.com/D233531 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1940502 gecko-commit: f01f55204b1567e35e3380ad65894da1a4a20252 gecko-reviewers: webdriver-reviewers, whimboo
This was failing for a few reasons. Recent changes (2024), where a page fragmentainer (page area) is wrapped inside a page border box fragment inside a page container fragment was one reason. Another reason was that page fragments haven't yet been added to the fragment builder when handling OOFs (SetChildFragmentStorage() is used). Furthermore, we failed to collect any anchor references at all in StitchedAnchorQueryCollector if the containing block was the LayoutView, since the layout view is on the outside of the fragmentation context. Change-Id: I77db8113046cc51c2d6428c33cf09d5c2c343bce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6135243 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/main@{#1404675}
…web-platform-tests#50018) See https://w3c.github.io/ServiceWorker/#serviceworkercontainer-interface Calling ServiceWorkerContainer.register() from a Window context is already covered by worker-constructor.html. This commit covers the case when it's called from a Worker context, more specifically particular dedicated, shared and service workers. This passes in Firefox with the patch from https://bugzilla.mozilla.org/show_bug.cgi?id=1940044 and https://bugzilla.mozilla.org/show_bug.cgi?id=1901492.
…rm-tests#50020) * [wdspec] Test for invalid subscription ids in unsubscribe * fix optional
…default Bug: 388544216 Change-Id: Ifd0b917b2059f406e4d184a54e419812c431aebb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6164473 Reviewed-by: Kyra Seevers <kyraseevers@chromium.org> Commit-Queue: Mike Taylor <miketaylr@chromium.org> Cr-Commit-Position: refs/heads/main@{#1404791}
Differential Revision: https://phabricator.services.mozilla.com/D173833 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1069931 gecko-commit: 86f62a648ef0e51bbb66ef7241df70b3b47a5eec gecko-reviewers: emilio, hsivonen, dholbert, frontend-codestyle-reviewers
… are preformatted The form of <https://discussions.apple.com/> handles newly inserted `Text` nodes asynchronously after pasted. Then, the text will be wrapped into `<p>` elements. However, the handler does not assume that multiple and consecutive `Text` nodes are inserted by a pasting. Therefore, they fail handling our pasted text which was split to each line and each preformatted linefeed. Chrome puts only one `Text` node at pasting multiline plaintext and following this behavior fixes the issue in the form. Therefore, we should follow the behavior at least for now. Differential Revision: https://phabricator.services.mozilla.com/D233619 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1940653 gecko-commit: e3417a5f4b06281e1fa68fdec8c6baf7248d11a4 gecko-reviewers: m_kato
These customizable select tests belong in the customizable-select subdirectory of the-select-element, so this patch moves them there. Change-Id: Ic5c8257a601d35f77d5ed09d97466878764d466b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6093890 Auto-Submit: Joey Arhar <jarhar@chromium.org> Reviewed-by: Traian Captan <tcaptan@chromium.org> Commit-Queue: Traian Captan <tcaptan@chromium.org> Cr-Commit-Position: refs/heads/main@{#1405042}
This CL introduces the parsing for the CSS property masonry-auto-tracks. This is part of: https://chromestatus.com/feature/5149560434589696 The properties are behind the CSSMasonryLayout feature flag. The spec definition for masonry-auto-tracks can be found here: https://drafts.csswg.org/css-grid-3/#propdef-masonry-auto-tracks Bug: 343257585 Change-Id: I33a72c50f662195934d1f7af8e199b477546fd89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6161598 Reviewed-by: Alison Maher <almaher@microsoft.com> Reviewed-by: Ethan Jimenez <ethavar@microsoft.com> Commit-Queue: Celeste Pan <celestepan@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1405087}
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
Differential Revision: https://phabricator.services.mozilla.com/D231736 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1934525 gecko-commit: 99281d5df65b0081d3066ad9a09e3d3d5b5b7c1c gecko-reviewers: emilio
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
* [wdspec] add basic context locator tests * Update webdriver/tests/bidi/browsing_context/locate_nodes/invalid.py * Update webdriver/tests/bidi/browsing_context/locate_nodes/locator.py
The current behavior of both `text-overflow: ellipsis` and `(-webkit-)line-clamp` with respect to positioning the ellipsis is that after the inline items are positioned, glyphs and other inline items will be truncated from the visual end of the line until there is enough space for the ellipsis to fit in the line box, and then the ellipsis is placed at that position. For `(-webkit-)line-clamp`, this disagrees with the upcoming specification, which says that rather than truncating glyphs one by one, instead all inline content should be truncated until the last break opportunity where the ellipsis would fit. Furthermore, inline content should be truncated logically, rather than visually. And there is an open discussion in w3c/csswg-drafts#10844 about where the ellipsis should be positioned in bidi content, which might not be at the visual end of the line. This means that the ellipsis should be taken into account at the line breaking phase. We tried laying out the ellipsis as part of `LineBreaker` and somehow including it in the `InlineItemResult`s it produces, but we found it was not always feasible. Instead, we shape the ellipsis in the `InlineLayoutAlgorithm`, pass its width to `LineBreaker`, and then in `LogicalLineBuilder` we add a `LogicalLineItem` for the ellipsis just before bidi reordering. This also fixes a long-standing bug where lines with the `line-clamp` ellipsis were not properly aligned or justified (bug 40265829). This happened because the line content was only trimmed, and the ellipsis was only shaped, after every `LogicalLineItem` was positioned according to the alignment and justification. With this patch, since the trimming and ellipsis shaping happens during line breaking, and the ellipsis `LogicalLineItem` is created at the same time as other `LogicalLineItem`s, the ellipsis behaves the same as any other inline content for alignment and justification. Some WPT and internal tests break with this change. Some of them are tests that were written expecting the previous behavior, and probably need to be updated. But others show that this implementation is incomplete. Therefore, we are putting this behind the runtime feature `CSSLineClampLineBreakingEllipsis`. Bug: 40336192, 40265829 Change-Id: I2d5a645899734b8dea5b0929906b7835b45bd50e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6106171 Reviewed-by: Andreu Botella <abotella@igalia.com> Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Andreu Botella <abotella@igalia.com> Cr-Commit-Position: refs/heads/main@{#1405438}
…form-tests#50024) * trusted-types-duplicate-names-without-enforcement.html: this test is about createPolicy(), it actually never executes the default policy so we cannot check the sink value. * worker-constructor.https.html: This checks a sink value, conditioning the expectations on the input string but that one is always a URL. Fix that by actually saving the seen parameters and testing them in the promise tests. * block-string-assignment-to-DOMWindowTimers-setTimeout-setInterval.html: some fixes were made in https://phabricator.services.mozilla.com/D232984 but it wrongly uses globalThisStr. We need to something similar to what DOMWindowTimers-setTimeout-setInterval.js does instead.
…attributes (web-platform-tests#50025) Add tests for setAttribute/setAttributeNS and content event handler attributes * Factor out the code generating the list of event handler attribute from TrustedTypePolicyFactory-getAttributeType-event-handler-content-attributes.tentative.html into a event-handler-attributes.mjs module. * Use this to write tests for setAttribute/setAttributeNS for all event handler attributes.
web-platform-tests#50022) These properties allow to change a script text or URL and need special attention. Existing tests for them are scattered over multiple files and check many other things. This new test focuses on checking whether setting these properties to a plain string would be blocked by a default policy, and what trusted type name and sink names would be passed to the corresponding create callback. We try setting the properties on HTMLDivElement, HTMLScriptElement or SVGScriptElement when they exist.
…butes (web-platform-tests#50046) This is a tentative test for [1] covering bullet 3 from [2]. There is a separate PR to cover the bullet 2 [3]. Most of these are probably already covered by other tests but assertions are scattered into multiple files as a side check in the default policy callback, so they are hard to understand and to guarantee they actually run (some mistakes were previously found about this in the past). Additionally, this new test cover both setAttribute and setAttributeNS and ensure the correct callback is called exactly once with proper attributes (e.g. to verify a call to setAttribute does not trigger the callback with the parameters of a reflected IDL attribute). [1] whatwg/dom#1268 [2] https://w3c.github.io/trusted-types/dist/spec/#get-trusted-type-data-for-attribute [3] web-platform-tests#50025
…eb-platform-tests#50043) * Remove unrelated checks from trusted-types-svg-script-set-href.html This test is intended to cover setting href [1] [2] but it also currently verifies some (currently not specified) unrelated behavior when setting the text of the script via innerHTML. A similar test exist in block-text-node-insertion-into-svg-script-element.html, but for a disconnected script. This PR just move the unrelated test to trusted-types-svg-script.html instead. [1] w3c/svgwg#934 [2] whatwg/dom#1268
When run with WebDriver-backed testdriver, this test hangs in all browsers [0] because the popup thinks that it's the testharness browsing context. This causes `test_driver.minimize_window()` to enqueue a command in the wrong window, which the harness never services. This CL removes `testharness(report).js` from the popup's markup and instructs testdriver to send commands to the testharness window instead with `set_test_context()` [1]. Internally, this `postMessage()`s the command with a unique ID identifying the popup [2]. This timeout doesn't occur for `content_shell` because it implements testdriver directly with nonstandard JS bindings. [0]: https://wpt.fyi/results/css/css-view-transitions/navigation/pageswap-in-hidden-doc-should-skip-transition.html?run_id=5078876080570368&run_id=5171541744812032&run_id=5150416142860288&run_id=5129648331816960 [1]: https://web-platform-tests.org/writing-tests/testdriver.html#test_driver.set_test_context [2]: https://github.com/web-platform-tests/wpt/blob/71341371/tools/wptrunner/wptrunner/testdriver-extra.js#L172-L173 Bug: None Change-Id: I62e740d5ccef2303c468dd91d0af368daee17dae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6160579 Commit-Queue: Jonathan Lee <jonathanjlee@google.com> Reviewed-by: Noam Rosenthal <nrosenthal@chromium.org> Cr-Commit-Position: refs/heads/main@{#1405572}
…in and max The specification doesn't say how to deal with percentages when determining the minimum and maximum size of a table grid, so follow the approach that Chromium uses. Essentially, figure out the "missing" percentage from the non-percentage columns and then use that to work backwards to fine the size of the percentage ones. This change is larger than one might expect, because this percentage approach shouldn't happen for tables that are descendants of a flex, grid or table container (except when there is an interceding absolute). We have to pass this information down when building the box tree. This will also make it easier to improve propagated text decorations in the future. Co-authored-by: Oriol Brufau <obrufau@igalia.com> Signed-off-by: Martin Robinson <mrobinson@igalia.com>
All other 2d.composite tests draw the background first and then draw the foreground. By using the same standard layout, it will be easier to merge the test body of all the 2d.composite tests, using a single common implementation. Bug: 40207206 Change-Id: I6c7fdd90e99b18f29deeca83e50e92a4a1ea8f0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6192520 Reviewed-by: Andres Ricardo Perez <andresrperez@chromium.org> Commit-Queue: Jean-Philippe Gravel <jpgravel@chromium.org> Cr-Commit-Position: refs/heads/main@{#1411633}
Bug: 391114797 Change-Id: I68d9ab267b1d56df30482d073cd56133bda6a8a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6179889 Reviewed-by: Henrik Boström <hbos@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/main@{#1411635}
Copy element/manual/context-attributes/getContextAttributes.html to an offscreen version. Update the element version to include doctype. Bug: 388437261 Change-Id: Ib6b1088ee7942e480a0d96f8bb38c4709ca61a6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6157844 Commit-Queue: ccameron chromium <ccameron@chromium.org> Reviewed-by: Aaron Krajeski <aaronhk@chromium.org> Cr-Commit-Position: refs/heads/main@{#1411641}
This WPT test, which originated in the WPT PR web-platform-tests#49881 (and ultimately in the WebKit commit WebKit/WebKit@0273a20), was incorrect because its `<link rel="match">` pointed to an unrelated reference. This patch fixes that, as well as moves the correct reference into the `line-clamp/reference` folder. Bug: 40336192, 386713385 Change-Id: I0bcddc40d04e6edc97d5e28835396d038d8e1261 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6198707 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Andreu Botella <abotella@igalia.com> Cr-Commit-Position: refs/heads/main@{#1411650}
Message event tasks coming from cross-origin postMessage was not correctly attributed in LoAF. Bug: 391284748 Change-Id: Icef7b88dd38ba810285b09a18a365a7df69a85cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6190632 Reviewed-by: Scott Haseley <shaseley@chromium.org> Commit-Queue: Noam Rosenthal <nrosenthal@chromium.org> Cr-Commit-Position: refs/heads/main@{#1411667}
Missing check for IsScrollButtonPseudoElement() in SelectorChecker. Bug: 392541996 Change-Id: I32f8c370b1b9eef4d506e2853cc21af1b8020b49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6198791 Commit-Queue: Daniil Sakhapov <sakhapov@chromium.org> Reviewed-by: Robert Flack <flackr@chromium.org> Reviewed-by: Daniil Sakhapov <sakhapov@chromium.org> Auto-Submit: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1411671}
By aligning the implementation of this test with the others in this file, it will be easier to merge all tests to use a single shared base implementation. Bug: 40207206 Change-Id: Ie5e91ac39eb34573dd2b8c6516b1e2653519de5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6192521 Commit-Queue: Jean-Philippe Gravel <jpgravel@chromium.org> Reviewed-by: Andres Ricardo Perez <andresrperez@chromium.org> Cr-Commit-Position: refs/heads/main@{#1411689}
If the signal passed into translate is already aborted, then reject with the signal reason. Fixed: 391906279 Change-Id: I0cc0cc585c5f8b18a3c2949cfcacd25f4e1665b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6195056 Reviewed-by: Ming-Ying Chung <mych@chromium.org> Commit-Queue: Nathan Memmott <memmott@chromium.org> Cr-Commit-Position: refs/heads/main@{#1411742}
The `interest-target-delay` shorthand is:
interest-target-delay = <time [0s,∞]>{1,2}
The first value is the `interest-target-show-delay`, and the
second is the `interest-target-hide-delay`.
Bug: 326681249
Change-Id: Id22ffce6d610ae0ad3530dc5e8c43678a39e25bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6197039
Reviewed-by: David Baron <dbaron@chromium.org>
Auto-Submit: Mason Freed <masonf@chromium.org>
Commit-Queue: Mason Freed <masonf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1411794}
Since links (<a>, <area>, SVG <a>) aren't interactive/focusable unless they have an href attribute, interesttarget should also not work on links without hrefs. Bug: 326681249 Change-Id: I3063d8e3654807da069731c66d1899e0e8ba06c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6199080 Commit-Queue: Mason Freed <masonf@chromium.org> Reviewed-by: David Baron <dbaron@chromium.org> Cr-Commit-Position: refs/heads/main@{#1411799}
This allows styling the element with the interesttarget attribute
depending on whether it currently has interest.
Also, one of the desired features is to easily be able to change the
show/hide delays for interesttarget depending on whether another
element already has interest. For example, when multiple elements
have interesttarget popovers, once the first one is showing, it
is common for the next one to show up more quickly or even
instantly. With the new pseudo class, this is possible via:
[interesttarget] {
interest-target-delay: 1s;
}
container:has(:has-interest) [interesttarget] {
interest-target-show-delay: 0s;
}
Bug: 326681249
Change-Id: I98d34e0f1a06bb6d80b153f3839678ada97aac08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6199201
Commit-Queue: Mason Freed <masonf@chromium.org>
Reviewed-by: David Baron <dbaron@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1411801}
We were painting collapsed borders without taking into account that some tracks might have been "removed" by `visibility: collapse`. This just sets the sizes of these tracks to zero. Note this implies that collapsed borders may overlap each other, or overlap cell contents, but this seems to match Blink. Signed-off-by: Oriol Brufau <obrufau@igalia.com>
The canvas element 2d.composite WPT tests are naming auxiliary canvases "canvas2", whereas the offscreen equivalent tests are naming them "offscreenCanvas2". Updating the offscreen tests to use the same name as the element tests will allow a follow-up CL to merge the two implementations to use a common shared test body. Bug: 40207206 Change-Id: Ib0c7335d41c9d77d1aca95b19518d4a8d0a877dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6192522 Commit-Queue: Jean-Philippe Gravel <jpgravel@chromium.org> Reviewed-by: Andres Ricardo Perez <andresrperez@chromium.org> Cr-Commit-Position: refs/heads/main@{#1411816}
This is required for the same reason dialog:modal resets interactivity according to spec in the top layer. So strictly not covered by the spec yet. Bug: 370065759 Change-Id: I98e4c54f3fab7ed432bef6331701f5d8305d3646 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6198205 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#1411818}
If an IDP calls IdentityProvider.close during the login flow, but did not send a login status header before that, we currently never reject the promise -- the FedCM flow just hangs forever. This makes it so that we reject the promise in this situation. Bug: 385209477 Change-Id: I322e1b3aef8205c398f1c31aafc9f55f56ff78c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6175704 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by: Nicolás Peña <npm@chromium.org> Cr-Commit-Position: refs/heads/main@{#1411864}
…ts#50321) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 6.12.0 to 6.13.0. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@67a2d40...ca877d9) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This change aligns this test with 2d.composite.canvas, which sets the canvas size explicitly. This will allow both tests to have the same shared implementation when we migrate them to the new test generator. Bug: 40207206 Change-Id: Ic282b4d66db7bf4559cce57153e44b2b58bab607 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6192523 Commit-Queue: Jean-Philippe Gravel <jpgravel@chromium.org> Reviewed-by: Andres Ricardo Perez <andresrperez@chromium.org> Cr-Commit-Position: refs/heads/main@{#1411904}
No test was currently using this feature, so the missing newline went unnoticed. This feature will be used in a follow-up CL, when we migrate the 2d.composite meta tests to the new test generator. Bug: 40207206 Change-Id: Iafa23787b7f4575b22f2fe26b4ff7017ad3c5910 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6192524 Reviewed-by: Andres Ricardo Perez <andresrperez@chromium.org> Commit-Queue: Jean-Philippe Gravel <jpgravel@chromium.org> Cr-Commit-Position: refs/heads/main@{#1411960}
This CL slightly simplifies the Observable async iterable subscription
flow by moving the abort signal check *after* the null `ScriptIterator`
check. This has two effects:
1. Allows us to remove one call to `ClearAbortAlgorithm()`, since we
are assigning the abort algorithm handle *after* the null
`ScriptIterator` check, and that check is the last opportunity to
cancel the subscription
2. Brings the async iterable subscription path inline with the *sync*
subscription path, which is ordered similarly [1]
This has a very subtle behavior change, so this CL also adds a test for
this case. The spec will be updated accordingly.
[1]:
https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/dom/observable.cc;l=1990-2019;drc=4b00956a8d971cf5ec8ec45a105b5dd8802d4a42
R=masonf
Bug: 363015168
Change-Id: Idf43bed901b1339d3581ce97c1cd02a0ac6b8b48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6199630
Reviewed-by: Mason Freed <masonf@chromium.org>
Commit-Queue: Dominic Farolino <dom@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1411976}
The background of this CL can be found here: WICG/webcomponents#1071 Currently, the main logic for retrieving the referenced target is implemented in GetShadowReferenceTarget. However, the function has a limitation where when it returns nullptr, it’s unclear whether it's due to the element lacking a shadow root with a specified referenceTarget, or because the referenceTarget has an invalid ID. This CL re-implements the retrieval logic in GetShadowReferenceTargetOrSelf, so instead of calling GetShadowReferenceTarget, it checks shadow root (recursively if nested layers) and returns the target element. If at any layer, referenceTarget is specified but the ID is invalid, it returns nullptr. This CL also updates 2 existing tests to verify nullptr is returned, and adds 3 more tests to verify nested cases and duplicate IDs. Note: 1. const Element* GetShadowReferenceTargetOrSelf is removed as it's not used. 2. content/test/data/accessibility/aria/aria-activedescendant-reference-target-dynamic-expected-blink.txt is rebaselined. The result matches the behavior where aria-activedescendant is set to an invalid ID, e.g., aria-activedescendant="invalid-id" in content/test/data/accessibility/aria/aria-activedescendant-reference-target-dynamic.html 3. we might be able to update all callers of GetShadowReferenceTarget to call GetShadowReferenceTargetOrSelf, which would make the logic easier to follow. This will be addressed in another CL. Bug: 374127243 Change-Id: I3972569e0f262911a1f888d3cf372f056e215bcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6199823 Reviewed-by: Mason Freed <masonf@chromium.org> Reviewed-by: Dan Clark <daniec@microsoft.com> Commit-Queue: Alex Keng <shihken@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1412034}
As proposed in w3c/ServiceWorker#1747, let me make the Chromium validate the requestMethod with https://fetch.spec.whatwg.org/#concept-method and https://fetch.spec.whatwg.org/#forbidden-method There is also ongoing spec change in: w3c/ServiceWorker#1748 Change-Id: I34b4ebb467b7e45bf36d972764c2cfaf8b059019 Bug: 391722219 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6191305 Reviewed-by: Keita Suzuki <suzukikeita@chromium.org> Reviewed-by: Shunya Shishido <sisidovski@chromium.org> Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Reviewed-by: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/main@{#1412047}
The test failed on headless_shell because document.execCommand() is returning false for copy and paste commands, causing the expected and actual results to not match. This CL resolves the issue by using test_driver.Actions() instead of execCommand for copy and paste operations. Bug: 366311855 Change-Id: I3a27acc1da37fdd20311ec8a7780c7905ee8952d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6197576 Reviewed-by: Siye Liu <siliu@microsoft.com> Reviewed-by: Sambamurthy Bandaru <sambamurthy.bandaru@microsoft.com> Reviewed-by: Kent Tamura <tkent@chromium.org> Reviewed-by: Mason Freed <masonf@chromium.org> Commit-Queue: Tanu Jain <tanujain@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1412050}
Anonymous text content child of ::scroll-button and ::scroll-marker should return its pseudo element parent as hit test result. Fixed: 391623869 Change-Id: I5de80192cf6a99eb5d326c5d0ef4e371a9d9b098 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6198872 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Daniil Sakhapov <sakhapov@chromium.org> Cr-Commit-Position: refs/heads/main@{#1412055}
…tform-tests#50295) See w3c/trusted-types#520 We add tests for: - Names that don't correspond to any event handler attribute. - Names that don't correspond to an event handler attribute on any element. - Names that don't correspond to an event handler attribute for the modified element.
…46072)" (web-platform-tests#50329) This reverts commit 6c91fbc (web-platform-tests#46072) as part of whatwg/html#10898.
When running the InsertListCommand function, it first unlistifies the node and then listifies it according to different scenarios. However, it only listifying the selected node instead of the entire child node. After this change, it will first listify the placeholder and then move the complete content of the child node into the placeholder's position. Changed few wpt according to spec. https://w3c.github.io/editing/docs/execCommand/#toggling-lists As queryCommandState('insertorderedlist') check if complete list is ordered or not (i.e. there should be no unordered nested list in it), changed few queryCommandState. Bug: 41058906 Change-Id: I308ea47d8a166b88d739d862189878b4081b8481 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6090765 Reviewed-by: Kent Tamura <tkent@chromium.org> Reviewed-by: Sambamurthy Bandaru <sambamurthy.bandaru@microsoft.com> Commit-Queue: Shweta Bindal <shwetabindal@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1412140}
The DejaVuSerif font was added since it provides different ligatures for Catalan and English. Not reusing <css/css-writing-modes/support/DejaVuSerif-webfont.woff> since that's an older version, see [1], not providing different ligatures. [2] Doesn't provide that functionality either. The newly added <DejaVuSerif.ttf> stems from [2]. [1] https://github.com/web-platform-tests/wpt/commits/master/css/css-writing-modes/support/DejaVuSerif-webfont.woff [2] http://sourceforge.net/projects/dejavu/files/dejavu/2.37/dejavu-fonts-ttf-2.37.zip [3] https://github.com/web-platform-tests/wpt/blob/c3b8c1186bb1f3a4aedaff5311126aacb90cc868/fonts/noto/noto-sans-v8-latin-regular.woff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
::slotted(*)::details-content(Add tests for::slotted(*)::details-contentweb-platform-tests/wpt#49408)::slotted(*)::file-selector-button(Add tests for::slotted(*)::file-selector-buttonweb-platform-tests/wpt#49407)document.write()/document.writeln().usagesslot being cached ([WebCryptoAPI] test cached usages slot as well web-platform-tests/wpt#49453)AllowSharedBufferSourcefor constantMouseEventand static methods ofEventaware of fractional coordinateswidthandheightofPointerEventto `doublehvc1.<profile>.<profile_compatibility>.<tier and level>.*javascript:URL navigations which check the order of the parent CSP and child CSP.javascript:URL navigation test which checks the parent's snapshotted CSP is checked during task creation, not during task execution (Add ajavascript:URL navigation test which checks the parent's snapshotted CSP is checked during task creation, not during task execution web-platform-tests/wpt#49403)javascript:URL navigation test which checks the parent's sna…" (Revert "Add ajavascript:URL navigation test which checks the parent's snapshotted CSP is checked during task creation, not during task execution" web-platform-tests/wpt#49523)promise_setup()error message ([testharness] Fix typo inpromise_setup()error message web-platform-tests/wpt#49550)<script integrity>WPT.stretchsizes on replaced absposcolumn-rule-stylepropertytestdriver.jsweb-platform-tests/wpt#49664) IDB WPTs: Extend fire-event-exception WPTs to run on workers [wptrunner] Add an --exclude-file, similar to --include-file DOMException: Add test for Error.isError webnn: validate context supports test graph part 1: Port test_bug1094000.html to WPT part 2: Port test_bug1355792.html to WPT part 3: Add some WPTs to check after deleting selected content across table cells part 4: Make HTMLEditor::AutoDeleteRangesHandler::Run and its callees handle some processes directly immediately after deleting content Add web-platform tests for grid container as flex item with auto repeat columns. Disable skipping line-clamped lines by default for now. Part 1 - Fix legacy flex container cross size alignment when computing intrinsic inline size. Part 2 - Fix flex item's stretched cross size with box-sizing:border-box when computing flex container's intrinsic inline size. Fix incorrect rounding in software rendering of feColorMatrix. [css-scroll-snap-2] Rename scroll-start-target to scroll-initial-target Make closeWatcher.requestClose() not require user activation Remove ::picker-icon forbrowsingContext.navigationFailedtest web-platform-tests/wpt#49718) Only generate ::column::scroll-marker elements that generate boxes De-flake two animated custom property WPTs [WebDriver BiDi] allow grapheme in key input ([WebDriver BiDi] allow grapheme in key input web-platform-tests/wpt#46301) WebKit export: align-content doesn't move atomic inlines (images, form controls) that are direct children (WebKit export of https://bugs.webkit.org/show_bug.cgi?id=267360 web-platform-tests/wpt#49903) WebKit export: background-clip: border-area should do nothing on the root WebKit export: [CSS] Fix the matching of :host combined with :not() (:host selector combination web-platform-tests/wpt#49611) WebKit export: [Grid][Replaced] Grid item which is an image with specified sizes fails to update when src changes (WebKit export of https://bugs.webkit.org/show_bug.cgi?id=277093 web-platform-tests/wpt#49899) WebKit export: Convert new scrollbar-gutter-root tests from LayoutTests to wpts* WebKit export: Disable line-fit-edge by default WebKit export: [css-nesting] Cascade interleaved rules in place WebKit export: [css-animations] Fix serialization and parsing of animation-name strings (WebKit export of https://bugs.webkit.org/show_bug.cgi?id=285347 web-platform-tests/wpt#49906) [attr] Look up attribute by local-name and null-namespace Reapply "IDB: direct reads for blobs" webnn: add fp16 conformance tests for element-wise logical operations Remove newline (instead of transforming to space) if adjacent to East-Asian punctuation character. Add a WPT for removeProperty("all"). WebKit export: [view-transitions] animation-name set from user agent dynamic stylesheet has extra quotes (WebKit export of https://bugs.webkit.org/show_bug.cgi?id=285295 web-platform-tests/wpt#49894) IDB: remove relaxed durability from some WPT. Fix input-text-datalist-removal.html on android Add test for modifying element IDs in disconnected shadow roots Fix test title Remove commented out tests from GlobalEventHandlers-onclick.html and minor tweaks. Fix some assertions for trusted type sink tests. Make HTMLEditor::ClearStyleAt stop forgetting removed line break Add cloning coverage fortext-box-trim-on-button.html<input type=file>in sideways-lr writing mode (WebKit export of https://bugs.webkit.org/show_bug.cgi?id=285545 web-platform-tests/wpt#49961)ConsumeTextBoxEdgefailsinvokersWPTs tocommand-and-commandforHTMLEditorreplace collapsible ASCII white-space with an NBSP if it's visible by a followingbut it's removed
HTMLEditor::HandlerInsertTextinsert oneTextwhen linefeeds are preformattedpageswap-in-hidden-doc-should-skip-transition.htmlhangdifferent-contexts.htmlHTMLEditor::OnModifyDocumentset top level edit sub-action before maintaining the white-space visibilityMouseEvent::DuplicatePrivateData()keep storing `mPresContextDocumentModifiedEventandHTMLEditor::OnModifyDocumentassume there is no editing hostcontent-visibility-auto-svg-text.htmlweb-platform-tests/wpt#50131)DebugOptionstoPreferencesand clean up/css/CSS2/tables/anonymous-table-box-width-001.xht/css/CSS2/tables/table-anonymous-objects-*line-clamp-content-height-with-dynamic-changeWPTinterest-target-delayshorthand for interesttarget props [7/N]