Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

External import map not loaded #49586

Merged
merged 2 commits into from
Dec 9, 2024
Merged

External import map not loaded #49586

merged 2 commits into from
Dec 9, 2024

Conversation

yoavweiss
Copy link
Contributor

It turns out that we don't have a test for step 31.1 of HTML's prepare the script element, which fires an error event when an external import map is declared.

This PR adds such a historical test (as loading the import map was previously specified).

@yoavweiss yoavweiss requested a review from annevk December 9, 2024 10:04
annevk
annevk approved these changes Dec 9, 2024
View reviewed changes
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can actually move this to the top-level directory as this is very much a requirement of the current specification that was not tested. I was not aware of that when advising on "historical".

@yoavweiss yoavweiss merged commit 24e7bf1 into web-platform-tests:master Dec 9, 2024
19 checks passed
@yoavweiss
Copy link
Contributor Author

Thanks for reviewing!!

@yoavweiss yoavweiss deleted the external_import_map_not_loaded branch December 9, 2024 15:06
@mbrodesser-Igalia mbrodesser-Igalia mentioned this pull request Jan 28, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annevk annevk annevk approved these changes

@domenic domenic Awaiting requested review from domenic

@hiroshige-g hiroshige-g Awaiting requested review from hiroshige-g

Assignees

@hiroshige-g hiroshige-g

Labels
import-maps
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yoavweiss @annevk @hiroshige-g @wpt-pr-bot