Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebDriver BiDi] Fix file test #50177

Merged
merged 1 commit into from
Jan 20, 2025
Merged

[WebDriver BiDi] Fix file test #50177

merged 1 commit into from
Jan 20, 2025

Conversation

Lightning00Blade
Copy link
Contributor

I took a look at this failing test and it seems that the test itself is the issue:
From the long we sent two different files:
Files in the first input.setFiles command:

"files": [ "/tmp/wdspec-t_9y6_4n/pytest/wdspec-0/path/to/noop.txt" ]

Files in second input.setFiles command:

 "files": [ "/tmp/wdspec-t_9y6_4n/pytest/wdspec-1/path/to/noop.txt" ]

This means that they will be treated as separate files.

This is happening because https://github.com/web-platform-tests/wpt/blob/fix-file-test/webdriver/tests/bidi/input/set_files/conftest.py#L18 we create a new temp folder in each invocation of the fixture.

Copy link
Contributor

@sadym-chromium sadym-chromium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch!

@Lightning00Blade
Copy link
Contributor Author

@lutien Can you please check why this was passing previously on Firefox?

Copy link
Contributor

@lutien lutien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@lutien
Copy link
Contributor

lutien commented Jan 20, 2025

@lutien Can you please check why this was passing previously on Firefox?

In Firefox at the moment we don't have access to the full path of the file only to the name of it, that's why we fail test_set_files_twice_same_in_different_folders test.

@Lightning00Blade Lightning00Blade merged commit 406d8b9 into master Jan 20, 2025
13 of 16 checks passed
@Lightning00Blade Lightning00Blade deleted the fix-file-test branch January 20, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants