Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wdspec] fix partition regression #49446

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Conversation

OrKoN
Copy link
Contributor

@OrKoN OrKoN commented Nov 29, 2024

Fixes a regression from #49420

@whimboo
Copy link
Contributor

whimboo commented Nov 29, 2024

@OrKoN could we get this done via https://phabricator.services.mozilla.com/D230696? If you are fine with the changes we could get it landed on our side so it will be upstream synced pretty quick.

@OrKoN
Copy link
Contributor Author

OrKoN commented Nov 29, 2024

@OrKoN could we get this done via https://phabricator.services.mozilla.com/D230696? If you are fine with the changes we could get it landed on our side so it will be upstream synced pretty quick.

sure, at the same time if someone reviews this one, it will land immediately. The change in https://phabricator.services.mozilla.com/D230696 seems to change more than was regressed and I am not sure that is correct (see https://bugzilla.mozilla.org/show_bug.cgi?id=1934045#c3)

@OrKoN OrKoN merged commit 643af85 into master Nov 29, 2024
19 checks passed
@OrKoN OrKoN deleted the orkon/fix-partition-regression branch November 29, 2024 22:58
@OrKoN
Copy link
Contributor Author

OrKoN commented Dec 2, 2024

@whimboo this has landed, let me know if you want to revert and re-land on your side first, thanks!

@whimboo
Copy link
Contributor

whimboo commented Dec 2, 2024

@whimboo this has landed, let me know if you want to revert and re-land on your side first, thanks!

I don't think it we should get backed out which would only require more CI checks to run. Thanks for the fix! We will take care of the remaining one on our side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants