WebKit export of https://bugs.webkit.org/show_bug.cgi?id=284048 #49881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jan 2, 2025
sadym-chromium
pushed a commit
that referenced
this pull request
Jan 14, 2025
…nt added dynamically (#49881) https://bugs.webkit.org/show_bug.cgi?id=284048 Co-authored-by: Alan Baradlay <zalan@apple.com>
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Jan 27, 2025
This WPT test, which originated in the WPT PR web-platform-tests/wpt#49881 (and ultimately in the WebKit commit WebKit/WebKit@0273a20), was incorrect because its `<link rel="match">` pointed to an unrelated reference. This patch fixes that, as well as moves the correct reference into the `line-clamp/reference` folder. Bug: 40336192, 386713385 Change-Id: I0bcddc40d04e6edc97d5e28835396d038d8e1261 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6198707 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Andreu Botella <abotella@igalia.com> Cr-Commit-Position: refs/heads/main@{#1411650}
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Jan 27, 2025
This WPT test, which originated in the WPT PR #49881 (and ultimately in the WebKit commit WebKit/WebKit@0273a20), was incorrect because its `<link rel="match">` pointed to an unrelated reference. This patch fixes that, as well as moves the correct reference into the `line-clamp/reference` folder. Bug: 40336192, 386713385 Change-Id: I0bcddc40d04e6edc97d5e28835396d038d8e1261 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6198707 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Andreu Botella <abotella@igalia.com> Cr-Commit-Position: refs/heads/main@{#1411650}
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Jan 27, 2025
This WPT test, which originated in the WPT PR #49881 (and ultimately in the WebKit commit WebKit/WebKit@0273a20), was incorrect because its `<link rel="match">` pointed to an unrelated reference. This patch fixes that, as well as moves the correct reference into the `line-clamp/reference` folder. Bug: 40336192, 386713385 Change-Id: I0bcddc40d04e6edc97d5e28835396d038d8e1261 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6198707 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Andreu Botella <abotella@igalia.com> Cr-Commit-Position: refs/heads/main@{#1411650}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jan 29, 2025
…ght-with-dynamic-change` WPT, a=testonly Automatic update from web-platform-tests [line-clamp] Fix `line-clamp-content-height-with-dynamic-change` WPT This WPT test, which originated in the WPT PR web-platform-tests/wpt#49881 (and ultimately in the WebKit commit WebKit/WebKit@0273a20), was incorrect because its `<link rel="match">` pointed to an unrelated reference. This patch fixes that, as well as moves the correct reference into the `line-clamp/reference` folder. Bug: 40336192, 386713385 Change-Id: I0bcddc40d04e6edc97d5e28835396d038d8e1261 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6198707 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Andreu Botella <abotella@igalia.com> Cr-Commit-Position: refs/heads/main@{#1411650} -- wpt-commits: 9b735772ebb1c7dffeb6770acd4bff4181ed6c60 wpt-pr: 50299
i3roly
pushed a commit
to i3roly/firefox-dynasty
that referenced
this pull request
Feb 5, 2025
…ght-with-dynamic-change` WPT, a=testonly Automatic update from web-platform-tests [line-clamp] Fix `line-clamp-content-height-with-dynamic-change` WPT This WPT test, which originated in the WPT PR web-platform-tests/wpt#49881 (and ultimately in the WebKit commit WebKit/WebKit@0273a20), was incorrect because its `<link rel="match">` pointed to an unrelated reference. This patch fixes that, as well as moves the correct reference into the `line-clamp/reference` folder. Bug: 40336192, 386713385 Change-Id: I0bcddc40d04e6edc97d5e28835396d038d8e1261 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6198707 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Andreu Botella <abotella@igalia.com> Cr-Commit-Position: refs/heads/main@{#1411650} -- wpt-commits: 9b735772ebb1c7dffeb6770acd4bff4181ed6c60 wpt-pr: 50299
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WebKit export from bug: [line-clamp] Incorrect clamped block height when content added dynamically