Fix mistakes in trusted-types*reporting tests. #50098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* expect_throws(): move out assert_unreached() out of the try scope. assert_unreached() throws [1] [2] so expect_throws() will not throw in case of failure. * trusted-types-reporting.html: Move the elements before the script to make sure they are already in the DOM when the tests are run. [1] https://github.com/web-platform-tests/wpt/blob/070a67f19da0b454068bc38ef40904403e5edca0/resources/testharness.js#L2391 [2] https://github.com/web-platform-tests/wpt/blob/070a67f19da0b454068bc38ef40904403e5edca0/resources/testharness.js#L4544
lukewarlow
reviewed
Jan 15, 2025
| @@ -39,7 +39,8 @@ | |||
| // Like assert_throws_*, but we don't care about the exact error. We just want | |||
| // to run the code and continue. | |||
| function expect_throws(fn) { | |||
| try { fn(); assert_unreached(); } catch (err) { /* ignore */ } | |||
| try { fn(); } catch (err) { return; /* ignore */ } | |||
There was a problem hiding this comment.
Current behavior is broken, see commit message.
There was a problem hiding this comment.
Ah apologies yeah that makes sense.
lukewarlow
reviewed
Jan 15, 2025
| @@ -6,6 +6,11 @@ | |||
| <script src="/content-security-policy/support/testharness-helper.js"></script> | |||
| </head> | |||
| <body> | |||
| <!-- Some elements for the tests to act on. --> | |||
There was a problem hiding this comment.
Did this cause a problem when running them? LGTM either way, just trying to understand the why?
There was a problem hiding this comment.
Same here, I noticed some flakiness in firefox after implementing svg href due to that. actually it seems there used to be a flakiness in chromium too (will remove that comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
expect_throws(): move out assert_unreached() out of the try scope. assert_unreached() throws [1] [2] so expect_throws() will not throw in case of failure.
trusted-types-reporting.html: Move the elements before the script to make sure they are already in the DOM when the tests are run.
[1]
wpt/resources/testharness.js
Line 2391 in 070a67f
[2]
wpt/resources/testharness.js
Line 4544 in 070a67f