Add tests for ::slotted(*)::details-content
#49408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nt1m
force-pushed
the
slotted-details-content
branch
from
844e607 to
c24b9ad
Compare
dbaron
approved these changes
Nov 27, 2024
| @@ -0,0 +1,6 @@ | |||
| <!doctype html> | |||
| <style> | |||
| ::details-content { color: green } | |||
There was a problem hiding this comment.
I would make this body { color: green} so that the test fails when ::details-content isn't supported.
There was a problem hiding this comment.
body would make the summary green too, I can wrap the text inside the details into a green span.
There was a problem hiding this comment.
Sounds good. (I forgot about the autogenerated summary text.)
nt1m
force-pushed
the
slotted-details-content
branch
from
c24b9ad to
8dd960f
Compare
dbaron
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.