Add tests for setAttribute/setAttributeNS and content event handler attributes #50025

fred-wang · 2025-01-10T15:10:23Z

    Never include unsupported event attributes into attributeNamesWithInterfaceName
    
    This is a small refactoring of https://github.com/web-platform-tests/wpt/pull/49473
    
    Instead of skipping unsupported attributes in the for loop, we filter
    them out when building the list.
    
    Technically, interfaceName is no longer used in the for loop, but we
    keep it in case that's needed for future setAttribute/setAttributeNS
    tests.

    Add tests for setAttribute/setAttributeNS and content event handler attributes
    
    * Factor out the code generating the list of event handler attribute from TrustedTypePolicyFactory-getAttributeType-event-handler-content-attributes.tentative.html into a event-handler-attributes.mjs module.
    * Use this to write tests for setAttribute/setAttributeNS for all event handler attributes.

…erfaceName This is a small refactoring of #49473 Instead of skipping unsupported attributes in the for loop, we filter them out when building the list. Technically, interfaceName is no longer used in the for loop, but we keep it in case that's needed for future setAttribute/setAttributeNS tests.

…ttributes * Factor out the code generating the list of event handler attribute from TrustedTypePolicyFactory-getAttributeType-event-handler-content-attributes.tentative.html into a event-handler-attributes.mjs module. * Use this to write tests for setAttribute/setAttributeNS for all event handler attributes.

…butes This is a tentative test for [1] covering bullet 3 from [2]. There is a separate PR to cover the bullet 2 [3]. Most of these are probably already covered by other tests but assertions are scattered into multiple files as a side check in the default policy callback, so they are hard to understand and to guarantee they actually run (some mistakes were previously found about this in the past). Additionnaly, this new test cover both setAttribute and setAttributeNS and ensure the correct callback is called exactly once with proper attributes (e.g. to verify a call to setAttribute does not trigger the callback with the parameters of a reflected IDL attribute). [1] whatwg/dom#1268 [2] https://w3c.github.io/trusted-types/dist/spec/#get-trusted-type-data-for-attribute [3] #50025

lukewarlow · 2025-01-13T13:52:38Z

trusted-types/support/event-handler-attributes.mjs

I don't think this needs an mjs extension? Isn't that a node paradigm rather than a browser one?

If it's used elsewhere in WPT then no worries.

no strong opinion on mjs, this is used by many other web platform tests though, so should be fine. IIRC, this was an MDN example too.

About implementing as a module: the rationale was to import WebIDLParser.js from event-handler-attributes.mjs directly, rather than having to do that from all HTML files.

lukewarlow

LGTM - See other comment and decide as appropriate.

…butes (#50046) This is a tentative test for [1] covering bullet 3 from [2]. There is a separate PR to cover the bullet 2 [3]. Most of these are probably already covered by other tests but assertions are scattered into multiple files as a side check in the default policy callback, so they are hard to understand and to guarantee they actually run (some mistakes were previously found about this in the past). Additionally, this new test cover both setAttribute and setAttributeNS and ensure the correct callback is called exactly once with proper attributes (e.g. to verify a call to setAttribute does not trigger the callback with the parameters of a reflected IDL attribute). [1] whatwg/dom#1268 [2] https://w3c.github.io/trusted-types/dist/spec/#get-trusted-type-data-for-attribute [3] #50025

…attributes (#50025) Add tests for setAttribute/setAttributeNS and content event handler attributes * Factor out the code generating the list of event handler attribute from TrustedTypePolicyFactory-getAttributeType-event-handler-content-attributes.tentative.html into a event-handler-attributes.mjs module. * Use this to write tests for setAttribute/setAttributeNS for all event handler attributes.

…butes (#50046) This is a tentative test for [1] covering bullet 3 from [2]. There is a separate PR to cover the bullet 2 [3]. Most of these are probably already covered by other tests but assertions are scattered into multiple files as a side check in the default policy callback, so they are hard to understand and to guarantee they actually run (some mistakes were previously found about this in the past). Additionally, this new test cover both setAttribute and setAttributeNS and ensure the correct callback is called exactly once with proper attributes (e.g. to verify a call to setAttribute does not trigger the callback with the parameters of a reflected IDL attribute). [1] whatwg/dom#1268 [2] https://w3c.github.io/trusted-types/dist/spec/#get-trusted-type-data-for-attribute [3] #50025

…S and non-event-handler attri…, a=testonly Automatic update from web-platform-tests Add tests for setAttribute/setAttributeNS and non-event-handler attributes (#50046) This is a tentative test for [1] covering bullet 3 from [2]. There is a separate PR to cover the bullet 2 [3]. Most of these are probably already covered by other tests but assertions are scattered into multiple files as a side check in the default policy callback, so they are hard to understand and to guarantee they actually run (some mistakes were previously found about this in the past). Additionally, this new test cover both setAttribute and setAttributeNS and ensure the correct callback is called exactly once with proper attributes (e.g. to verify a call to setAttribute does not trigger the callback with the parameters of a reflected IDL attribute). [1] whatwg/dom#1268 [2] https://w3c.github.io/trusted-types/dist/spec/#get-trusted-type-data-for-attribute [3] web-platform-tests/wpt#50025 -- wpt-commits: 35de05425036bf714b270c76dd00892900002963 wpt-pr: 50046

…S and non-event-handler attri…, a=testonly Automatic update from web-platform-tests Add tests for setAttribute/setAttributeNS and non-event-handler attributes (#50046) This is a tentative test for [1] covering bullet 3 from [2]. There is a separate PR to cover the bullet 2 [3]. Most of these are probably already covered by other tests but assertions are scattered into multiple files as a side check in the default policy callback, so they are hard to understand and to guarantee they actually run (some mistakes were previously found about this in the past). Additionally, this new test cover both setAttribute and setAttributeNS and ensure the correct callback is called exactly once with proper attributes (e.g. to verify a call to setAttribute does not trigger the callback with the parameters of a reflected IDL attribute). [1] whatwg/dom#1268 [2] https://w3c.github.io/trusted-types/dist/spec/#get-trusted-type-data-for-attribute [3] web-platform-tests/wpt#50025 -- wpt-commits: 35de05425036bf714b270c76dd00892900002963 wpt-pr: 50046 UltraBlame original commit: 4846e5ab139c44c223566809053c5948cd2d8d16

…S and non-event-handler attri…, a=testonly Automatic update from web-platform-tests Add tests for setAttribute/setAttributeNS and non-event-handler attributes (#50046) This is a tentative test for [1] covering bullet 3 from [2]. There is a separate PR to cover the bullet 2 [3]. Most of these are probably already covered by other tests but assertions are scattered into multiple files as a side check in the default policy callback, so they are hard to understand and to guarantee they actually run (some mistakes were previously found about this in the past). Additionally, this new test cover both setAttribute and setAttributeNS and ensure the correct callback is called exactly once with proper attributes (e.g. to verify a call to setAttribute does not trigger the callback with the parameters of a reflected IDL attribute). [1] whatwg/dom#1268 [2] https://w3c.github.io/trusted-types/dist/spec/#get-trusted-type-data-for-attribute [3] web-platform-tests/wpt#50025 -- wpt-commits: 35de05425036bf714b270c76dd00892900002963 wpt-pr: 50046

fred-wang requested a review from lukewarlow January 10, 2025 15:10

wpt-pr-bot added trusted-types wg-s_webappsec labels Jan 10, 2025

wpt-pr-bot assigned mikewest Jan 10, 2025

wpt-pr-bot requested a review from mikewest January 10, 2025 15:10

fred-wang changed the title ~~Never include unsupported event attributes into attributeNamesWithInt…~~ Add tests for setAttribute/setAttributeNS and content event handler attributes Jan 10, 2025

fred-wang mentioned this pull request Jan 10, 2025

Improve test coverage of sink values w3c/trusted-types#494

Closed

fred-wang mentioned this pull request Jan 13, 2025

Add tests for setAttribute/setAttributeNS and non-event-handler attri… #50046

Merged

add assert to ensure createScript is only called once

4c5a05c

lukewarlow reviewed Jan 13, 2025

View reviewed changes

lukewarlow approved these changes Jan 13, 2025

View reviewed changes

fred-wang merged commit d22e0bf into master Jan 13, 2025
19 checks passed

fred-wang deleted the tt-event-handle-attribute-refactoring branch January 13, 2025 15:04

mbrodesser-Igalia mentioned this pull request Jan 28, 2025

AddTestCheckingLangAttributeAffectsLigatures mbrodesser-Igalia/wpt#5

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add tests for setAttribute/setAttributeNS and content event handler attributes #50025

Add tests for setAttribute/setAttributeNS and content event handler attributes #50025

fred-wang commented Jan 10, 2025 •

edited

Loading

lukewarlow Jan 13, 2025

fred-wang Jan 13, 2025

lukewarlow left a comment

Add tests for setAttribute/setAttributeNS and content event handler attributes #50025

Add tests for setAttribute/setAttributeNS and content event handler attributes #50025

Conversation

fred-wang commented Jan 10, 2025 • edited Loading

lukewarlow Jan 13, 2025

Choose a reason for hiding this comment

fred-wang Jan 13, 2025

Choose a reason for hiding this comment

lukewarlow left a comment

Choose a reason for hiding this comment

fred-wang commented Jan 10, 2025 •

edited

Loading