Add some Media Capabilities API tests #49140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per spec draft at https://www.w3.org/TR/2024/WD-media-capabilities-20241007/ - Test for 'does not imply a codec' - Test for 'valid MIME type string' - Test for 'single media codec'
markafoltz
requested changes
Nov 19, 2024
|
I requested merge rights in #49250 so I may be able to merge this myself 👏 |
|
Thanks. I'll update the tests per your suggestions and add some similar tests for encodingInfo. |
|
I added encodingInfo tests, fixed a minor issue in the decodingInfo tests I added (with the framerate option), as well for your suggested edits. |
markafoltz
approved these changes
Nov 26, 2024
| @@ -180,10 +233,10 @@ promise_test(t => { | |||
| width: 800, | |||
| height: 600, | |||
| bitrate: 3000, | |||
| framerate: '24000/1001', | |||
| framerate: 24, | |||
There was a problem hiding this comment.
Was this change intentional? The test suggests the framerate needs to be 'x/y'
There was a problem hiding this comment.
Sorry, no, I just fixed that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per spec draft at https://www.w3.org/TR/2024/WD-media-capabilities-20241007/
PTAL @markafoltz