Test document.currentScript when script is moved during evaluation
#20775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
annevk,
domenic,
foolip,
jdm,
jgraham,
zcorpan and
zqzhang
domenic
approved these changes
Dec 13, 2019
html/semantics/scripting-1/the-script-element/moving-between-documents-during-evaluation.html
Outdated
Show resolved
Hide resolved
domenic
added a commit
to whatwg/html
that referenced
this pull request
Dec 13, 2019
One normative fix: by saving the script element's node document before evaluation, this properly changes that document's currentScript back after evaluation. As previously written, a script that moved during evaluation would cause its new node document's currentScript to update. Tests: web-platform-tests/wpt#20775 Editorial cleanups: * Use a named argument, scriptElement * Use the saved document variable throughout * Cleanup source formatting * Remove <!-- SCRIPT EXEC --> comments
domenic
added a commit
to whatwg/html
that referenced
this pull request
Jan 9, 2020
One normative fix: by saving the script element's node document before evaluation, this properly changes that document's currentScript back after evaluation. As previously written, a script that moved during evaluation would cause its new node document's currentScript to update. Tests: web-platform-tests/wpt#20775 Editorial cleanups: * Use a named argument, scriptElement * Use the saved document variable throughout * Cleanup source formatting * Remove <!-- SCRIPT EXEC --> comments
|
@hiroshige-g there were Taskcluster troubles. If you try rebasing this PR it'll probably be fine now. |
|
Trying to reboot CI so we can get this merged. |
In the spec before whatwg/html#5154, `script element's node document` is re-evaluated after script evaluation, and thus if a script is moved to another Document during its own evaluation, `currentScript` of the *new* document could be updated. After web-platform-tests#5154, `currentScript` is always set/reset on the same Document, which is expected, and tested so here.
domenic
force-pushed
the
scripts-between-documents-during-evaluation
branch
from
1deb1fb
to
304daa9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the spec before whatwg/html#5154,
script element's node documentis re-evaluated after script evaluation,and thus if a script is moved to another Document during its own evaluation,
currentScriptof the new document could be updated.After #5154,
currentScriptis always set/reset on the same Document,which is expected, and tested so here.
Browser implementations already follow the new spec behavior (as expected).